Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(130)

Issue 1558123002: Allow enable_topchrome_md to be overridden in gn build (Closed)

Created:
4 years, 11 months ago by Tomasz Moniuszko
Modified:
4 years, 11 months ago
Reviewers:
brettw
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Allow enable_topchrome_md to be overridden in gn build BUG= Committed: https://crrev.com/9ba45bad02629185e58b93e0ae7613a95d9f6662 Cr-Commit-Position: refs/heads/master@{#368298}

Patch Set 1 #

Total comments: 1

Patch Set 2 : Add flag doc #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -2 lines) Patch
M build/config/ui.gni View 1 2 chunks +4 lines, -2 lines 0 comments Download

Messages

Total messages: 10 (3 generated)
Tomasz Moniuszko
4 years, 11 months ago (2016-01-05 09:42:40 UTC) #2
brettw
lgtm https://codereview.chromium.org/1558123002/diff/1/build/config/ui.gni File build/config/ui.gni (right): https://codereview.chromium.org/1558123002/diff/1/build/config/ui.gni#newcode50 build/config/ui.gni:50: enable_topchrome_md = is_chromeos || is_win || is_linux Can ...
4 years, 11 months ago (2016-01-05 20:09:25 UTC) #3
Tomasz Moniuszko
On 2016/01/05 20:09:25, brettw wrote: > Can you provide documentation for this flag? i.e. what ...
4 years, 11 months ago (2016-01-07 11:11:21 UTC) #4
brettw
seems fine. still lgtm
4 years, 11 months ago (2016-01-07 18:52:55 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1558123002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1558123002/20001
4 years, 11 months ago (2016-01-08 08:10:12 UTC) #7
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 11 months ago (2016-01-08 08:48:12 UTC) #8
commit-bot: I haz the power
4 years, 11 months ago (2016-01-08 08:49:18 UTC) #10
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/9ba45bad02629185e58b93e0ae7613a95d9f6662
Cr-Commit-Position: refs/heads/master@{#368298}

Powered by Google App Engine
This is Rietveld 408576698