Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(233)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: src/i18n.cc

Issue 1558113002: Add UseCounters for various standards-related code paths (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Don't expose patternSymbol Created 4 years, 12 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « src/heap/heap.h ('k') | src/js/harmony-unicode-regexps.js » ('j') | src/js/harmony-unicode-regexps.js » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/i18n.cc
diff --git a/src/i18n.cc b/src/i18n.cc
index 4f5431fa95fd9904dc4f858cdc9e66f62a74638c..0bfc122f6b87871c9b5eb7ddf5ea39bb74b14d05 100644
--- a/src/i18n.cc
+++ b/src/i18n.cc
@@ -145,7 +145,7 @@ void SetResolvedDateSettings(Isolate* isolate,
icu::UnicodeString pattern;
date_format->toPattern(pattern);
JSObject::SetProperty(
- resolved, factory->NewStringFromStaticChars("pattern"),
+ resolved, handle(isolate->heap()->pattern_symbol(), isolate),
adamk 2016/01/05 19:10:09 "factory->pattern_symbol()" will give you a handle
Dan Ehrenberg 2016/01/06 03:20:54 Done
factory->NewStringFromTwoByte(
Vector<const uint16_t>(
reinterpret_cast<const uint16_t*>(pattern.getBuffer()),
@@ -367,7 +367,7 @@ void SetResolvedNumberSettings(Isolate* isolate,
icu::UnicodeString pattern;
number_format->toPattern(pattern);
JSObject::SetProperty(
- resolved, factory->NewStringFromStaticChars("pattern"),
+ resolved, handle(isolate->heap()->pattern_symbol(), isolate),
adamk 2016/01/05 19:10:09 ditto
Dan Ehrenberg 2016/01/06 03:20:54 ditto
factory->NewStringFromTwoByte(
Vector<const uint16_t>(
reinterpret_cast<const uint16_t*>(pattern.getBuffer()),
« no previous file with comments | « src/heap/heap.h ('k') | src/js/harmony-unicode-regexps.js » ('j') | src/js/harmony-unicode-regexps.js » ('J')

Powered by Google App Engine
This is Rietveld 408576698