Add UseCounters for various standards-related code paths

src/js/i18n.js

 // Copyright 2013 the V8 project authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 // ECMAScript 402 API implementation.
 
 /**
  * Intl object is a single object that has some named properties,
  * all of which are constructors.
  */
@@ skipping 15 matching lines @@
 var GlobalDate = global.Date;
 var GlobalNumber = global.Number;
 var GlobalRegExp = global.RegExp;
 var GlobalString = global.String;
 var MakeError;
 var MakeRangeError;
 var MakeTypeError;
 var MathFloor;
 var ObjectDefineProperties = utils.ImportNow("ObjectDefineProperties");
 var ObjectDefineProperty = utils.ImportNow("ObjectDefineProperty");
+var patternSymbol = utils.ImportNow("pattern_symbol");
 var RegExpTest;
 var StringIndexOf;
 var StringLastIndexOf;
 var StringMatch;
 var StringReplace;
 var StringSplit;
 var StringSubstr;
 var StringSubstring;
+const kIntlPattern = 15;
 
 utils.Import(function(from) {
   ArrayIndexOf = from.ArrayIndexOf;
   ArrayJoin = from.ArrayJoin;
   ArrayPush = from.ArrayPush;
   IsFinite = from.IsFinite;
   IsNaN = from.IsNaN;
   MakeError = from.MakeError;
   MakeRangeError = from.MakeRangeError;
   MakeTypeError = from.MakeTypeError;
@@ skipping 1096 matching lines @@
 
   var requestedLocale = locale.locale + extension;
   var resolved = ObjectDefineProperties({}, {
     currency: {writable: true},
     currencyDisplay: {writable: true},
     locale: {writable: true},
     maximumFractionDigits: {writable: true},
     minimumFractionDigits: {writable: true},
     minimumIntegerDigits: {writable: true},
     numberingSystem: {writable: true},
+    pattern: {get() {
+      %IncrementUseCounter(kIntlPattern);
+      return this[patternSymbol];
+    }},
     requestedLocale: {value: requestedLocale, writable: true},
     style: {value: internalOptions.style, writable: true},
     useGrouping: {writable: true}
   });
   if (%HasOwnProperty(internalOptions, 'minimumSignificantDigits')) {
     defineWEProperty(resolved, 'minimumSignificantDigits', UNDEFINED);
   }
   if (%HasOwnProperty(internalOptions, 'maximumSignificantDigits')) {
     defineWEProperty(resolved, 'maximumSignificantDigits', UNDEFINED);
   }
@@ skipping 384 matching lines @@
   var resolved = ObjectDefineProperties({}, {
     calendar: {writable: true},
     day: {writable: true},
     era: {writable: true},
     hour12: {writable: true},
     hour: {writable: true},
     locale: {writable: true},
     minute: {writable: true},
     month: {writable: true},
     numberingSystem: {writable: true},
-    pattern: {writable: true},
+    [patternSymbol]: {writable: true},
+    pattern: {get() {

[adamk, 2016/01/05 19:10:09]

Don't you want a setter too, since the old property was writable?

[Dan Ehrenberg, 2016/01/06 03:20:55]

Oh, good point. Done.

+      %IncrementUseCounter(kIntlPattern);
+      return this[patternSymbol];
+    }},
     requestedLocale: {value: requestedLocale, writable: true},
     second: {writable: true},
     timeZone: {writable: true},
     timeZoneName: {writable: true},
     tz: {value: tz, writable: true},
     weekday: {writable: true},
     year: {writable: true}
   });
 
   var formatter = %CreateDateTimeFormat(
@@ skipping 56 matching lines @@
       'islamic': 'islamic',
       'hebrew': 'hebrew',
       'chinese': 'chinese',
       'indian': 'indian',
       'coptic': 'coptic',
       'ethiopic': 'ethiopic',
       'ethiopic-amete-alem': 'ethioaa'
     };
 
     var format = this;
-    var fromPattern = fromLDMLString(format.resolved.pattern);
+    var fromPattern = fromLDMLString(format.resolved[patternSymbol]);
     var userCalendar = ICU_CALENDAR_MAP[format.resolved.calendar];
     if (IS_UNDEFINED(userCalendar)) {
       // Use ICU name if we don't have a match. It shouldn't happen, but
       // it would be too strict to throw for this.
       userCalendar = format.resolved.calendar;
     }
 
     var locale = getOptimalLanguageTag(format.resolved.requestedLocale,
                                        format.resolved.locale);
 
@@ skipping 461 matching lines @@
     }
 
     var locales = %_Arguments(0);
     var options = %_Arguments(1);
     return toLocaleDateTime(
         this, locales, options, 'time', 'time', 'dateformattime');
   }
 );
 
 })