Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(536)

Side by Side Diff: src/js/harmony-unicode-regexps.js

Issue 1558113002: Add UseCounters for various standards-related code paths (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Don't expose patternSymbol Created 4 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2014 the V8 project authors. All rights reserved. 1 // Copyright 2014 the V8 project authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 (function(global, utils) { 5 (function(global, utils) {
6 6
7 'use strict'; 7 'use strict';
8 8
9 %CheckIsBootstrapping(); 9 %CheckIsBootstrapping();
10 10
11 // ------------------------------------------------------------------- 11 // -------------------------------------------------------------------
12 // Imports 12 // Imports
13 13
14 var GlobalRegExp = global.RegExp; 14 var GlobalRegExp = global.RegExp;
15 var GlobalRegExpPrototype = GlobalRegExp.prototype; 15 var GlobalRegExpPrototype = GlobalRegExp.prototype;
16 var MakeTypeError; 16 var MakeTypeError;
17 17
18 const kRegExpPrototypeUnicodeGetter = 11;
adamk 2016/01/05 19:10:09 Hmm, it seems like only one other place (harmony-r
Dan Ehrenberg 2016/01/06 03:20:54 Alright, used macros instead.
19
18 utils.Import(function(from) { 20 utils.Import(function(from) {
19 MakeTypeError = from.MakeTypeError; 21 MakeTypeError = from.MakeTypeError;
20 }); 22 });
21 23
22 // ------------------------------------------------------------------- 24 // -------------------------------------------------------------------
23 25
24 // ES6 21.2.5.15. 26 // ES6 21.2.5.15.
25 function RegExpGetUnicode() { 27 function RegExpGetUnicode() {
26 if (!IS_REGEXP(this)) { 28 if (!IS_REGEXP(this)) {
29 if (this === GlobalRegExpPrototype) {
30 %IncrementUseCounter(kRegExpPrototypeUnicodeGetter);
31 }
27 throw MakeTypeError(kRegExpNonRegExp, "RegExp.prototype.unicode"); 32 throw MakeTypeError(kRegExpNonRegExp, "RegExp.prototype.unicode");
28 } 33 }
29 return !!REGEXP_UNICODE(this); 34 return !!REGEXP_UNICODE(this);
30 } 35 }
31 %FunctionSetName(RegExpGetUnicode, "RegExp.prototype.unicode"); 36 %FunctionSetName(RegExpGetUnicode, "RegExp.prototype.unicode");
32 %SetNativeFlag(RegExpGetUnicode); 37 %SetNativeFlag(RegExpGetUnicode);
33 38
34 utils.InstallGetter(GlobalRegExp.prototype, 'unicode', RegExpGetUnicode); 39 utils.InstallGetter(GlobalRegExp.prototype, 'unicode', RegExpGetUnicode);
35 40
36 }) 41 })
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698