core/include/fpdfapi/fpdf_parser.h - Issue 1558083002: Change CPDF_SyntaxParser::GetNextWord() to not pass by non-const ref.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: core/include/fpdfapi/fpdf_parser.h

Issue 1558083002: Change CPDF_SyntaxParser::GetNextWord() to not pass by non-const ref. (Closed) Base URL: https://pdfium.googlesource.com/pdfium@master

Patch Set: Created 4 years, 12 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: core/include/fpdfapi/fpdf_parser.h

diff --git a/core/include/fpdfapi/fpdf_parser.h b/core/include/fpdfapi/fpdf_parser.h

index a49fb29d9ca9d5f151bb9e8403018655ecf2f419..ab64c21f2c822de6d9480c435ac3f8beee66d9bf 100644

--- a/core/include/fpdfapi/fpdf_parser.h

+++ b/core/include/fpdfapi/fpdf_parser.h

@@ -297,7 +297,7 @@ class CPDF_SyntaxParser {

FX_BOOL ReadBlock(uint8_t* pBuf, FX_DWORD size);

- CFX_ByteString GetNextWord(FX_BOOL& bIsNumber);

+ CFX_ByteString GetNextWord(bool* bIsNumber);

protected:

friend class CPDF_Parser;

@@ -311,7 +311,7 @@ class CPDF_SyntaxParser {

FX_BOOL GetCharAtBackward(FX_FILESIZE pos, uint8_t& ch);

- void GetNextWord();

+ bool GetNextWordInternal();

bool IsWholeWord(FX_FILESIZE startpos,

FX_FILESIZE limit,

@@ -353,8 +353,6 @@ class CPDF_SyntaxParser {

FX_DWORD m_WordSize;

- FX_BOOL m_bIsNumber;

FX_FILESIZE m_dwWordPos;

};

« no previous file with comments | « no previous file | core/src/fpdfapi/fpdf_parser/fpdf_parser_fdf.cpp » ('j') | core/src/fpdfapi/fpdf_parser/fpdf_parser_parser.cpp » ('J')