Issue 155808: Widen ExtensionUnpacker_Test suppression yet again

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 155808: Widen ExtensionUnpacker_Test suppression yet again (Closed)

Created:
11 years, 5 months ago by stuartmorgan

Modified:
9 years, 7 months ago

Reviewers:
dank

CC:
chromium-reviews_googlegroups.com

Visibility:
Public.

Description

Widen ExtensionUnpacker_Test suppression yet again BUG=17129 TEST=Greener Mac valgind unit_test bot. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=21122

Patch Set 1 #

Created: 11 years, 5 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -1 line)			Patch
	M	tools/valgrind/memcheck/suppressions.txt	View		1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

not_the_right_dank

11 years, 5 months ago (2009-07-20 22:07:29 UTC) #2

LGTM

On Mon, Jul 20, 2009 at 10:05 PM, <stuartmorgan@chromium.org> wrote:
>
> Reviewers: dank,
>
> Description:
> Widen ExtensionUnpacker_Test suppression yet again
>
> BUG=3D17129
> TEST=3DGreener Mac valgind unit_test bot.
>
> Please review this at http://codereview.chromium.org/155808
>
> Affected files:
> =A0M tools/valgrind/memcheck/suppressions.txt
>
>
> Index: tools/valgrind/memcheck/suppressions.txt
> diff --git a/tools/valgrind/memcheck/suppressions.txt
> b/tools/valgrind/memcheck/suppressions.txt
> index
> b90691e8717d0cd2f7601210d6c5036d46f4b06c..caed1dbf143370fa1158255bbc26c33=
08b5ba008
> 100644
> --- a/tools/valgrind/memcheck/suppressions.txt
> +++ b/tools/valgrind/memcheck/suppressions.txt
> @@ -929,7 +929,7 @@
> =A0 =A0# Anonymous namespaces requires wildcard to match on both mac and =
linux
> =A0 =A0bug_17129
> =A0 =A0Memcheck:Leak
> - =A0 fun:_Znwj
> + =A0 fun:_Znw*
> =A0 =A0fun:*UtilityProcessHostTest_ExtensionUnpacker_Test8TestBodyEv
> =A0}
> =A0{
>
>
>

Expand Messages | Collapse Messages