Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(42)

Issue 1558053002: Ship destructuring assignment (Closed)

Created:
4 years, 11 months ago by adamk
Modified:
4 years, 11 months ago
CC:
Michael Hablich, rossberg, v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Ship destructuring assignment BUG=v8:811 LOG=y CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_chromium_rel_ng;tryserver.blink:linux_blink_rel Committed: https://crrev.com/7ab3ccb03171f28ead83a36df576843c240304fe Cr-Commit-Position: refs/heads/master@{#33124}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -9 lines) Patch
M src/flag-definitions.h View 2 chunks +9 lines, -9 lines 0 comments Download

Messages

Total messages: 18 (9 generated)
adamk
4 years, 11 months ago (2016-01-05 00:51:20 UTC) #2
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1558053002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1558053002/1
4 years, 11 months ago (2016-01-05 00:51:31 UTC) #4
commit-bot: I haz the power
Dry run: Transient error: Too many "tryserver.chromium.linux:linux_chromium_rel_ng,tryserver.blink:linux_blink_rel" delimiters in ":". Correct syntax is "tryserver:bot1,bot2;tryserver2:bot3,bot4;".
4 years, 11 months ago (2016-01-05 00:51:32 UTC) #6
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1558053002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1558053002/1
4 years, 11 months ago (2016-01-05 00:52:31 UTC) #9
Dan Ehrenberg
lgtm
4 years, 11 months ago (2016-01-05 01:19:39 UTC) #10
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 11 months ago (2016-01-05 03:03:59 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1558053002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1558053002/1
4 years, 11 months ago (2016-01-05 18:50:04 UTC) #14
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 11 months ago (2016-01-05 19:01:16 UTC) #16
commit-bot: I haz the power
4 years, 11 months ago (2016-01-05 19:01:51 UTC) #18
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/7ab3ccb03171f28ead83a36df576843c240304fe
Cr-Commit-Position: refs/heads/master@{#33124}

Powered by Google App Engine
This is Rietveld 408576698