Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2140)

Unified Diff: chrome/browser/sync/test_profile_sync_service.cc

Issue 15580002: Make use of InvalidationService (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: More review fixes Created 7 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/sync/test_profile_sync_service.cc
diff --git a/chrome/browser/sync/test_profile_sync_service.cc b/chrome/browser/sync/test_profile_sync_service.cc
index 73415c06988c5563222f6696160b8b0e453710c9..a0e3b2fc545675bd5fa3f82e99f9bd2abaccffde 100644
--- a/chrome/browser/sync/test_profile_sync_service.cc
+++ b/chrome/browser/sync/test_profile_sync_service.cc
@@ -36,7 +36,6 @@ namespace browser_sync {
SyncBackendHostForProfileSyncTest::SyncBackendHostForProfileSyncTest(
Profile* profile,
const base::WeakPtr<SyncPrefs>& sync_prefs,
- const base::WeakPtr<invalidation::InvalidatorStorage>& invalidator_storage,
syncer::TestIdFactory& id_factory,
base::Closure& callback,
bool set_initial_sync_ended_on_init,
@@ -44,7 +43,7 @@ SyncBackendHostForProfileSyncTest::SyncBackendHostForProfileSyncTest(
bool fail_initial_download,
syncer::StorageOption storage_option)
: browser_sync::SyncBackendHost(
- profile->GetDebugName(), profile, sync_prefs, invalidator_storage),
+ profile->GetDebugName(), profile, sync_prefs),
weak_ptr_factory_(this),
id_factory_(id_factory),
callback_(callback),
@@ -113,8 +112,13 @@ void SyncBackendHostForProfileSyncTest::RequestConfigureSyncer(
if (fail_initial_download_)
failed_configuration_types = types_to_config;
+ // The first parameter there shoudl be the set of enabled types. That's not
akalin 2013/05/24 22:58:46 shoudl -> should
rlarocque 2013/05/29 00:37:55 Done.
+ // something we have access to from this strange test harness. We'll just
+ // send back the list of newly configured types instead and hope it doesn't
+ // break anything.
FinishConfigureDataTypesOnFrontendLoop(
syncer::Difference(types_to_config, failed_configuration_types),
+ syncer::Difference(types_to_config, failed_configuration_types),
failed_configuration_types,
ready_task);
}
@@ -176,16 +180,6 @@ void SyncBackendHostForProfileSyncTest
}
}
-void SyncBackendHostForProfileSyncTest::EmitOnInvalidatorStateChange(
- syncer::InvalidatorState state) {
- frontend()->OnInvalidatorStateChange(state);
-}
-
-void SyncBackendHostForProfileSyncTest::EmitOnIncomingInvalidation(
- const syncer::ObjectIdInvalidationMap& invalidation_map) {
- frontend()->OnIncomingInvalidation(invalidation_map);
-}
-
void SyncBackendHostForProfileSyncTest::ContinueInitialization(
const syncer::WeakHandle<syncer::JsBackend>& js_backend,
const syncer::WeakHandle<syncer::DataTypeDebugInfoListener>&
@@ -291,7 +285,6 @@ void TestProfileSyncService::CreateBackend() {
backend_.reset(new browser_sync::SyncBackendHostForProfileSyncTest(
profile(),
sync_prefs_.AsWeakPtr(),
- invalidator_storage_.AsWeakPtr(),
id_factory_,
callback_,
set_initial_sync_ended_on_init_,

Powered by Google App Engine
This is Rietveld 408576698