Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2653)

Unified Diff: chrome/browser/invalidation/ticl_invalidation_service.h

Issue 15580002: Make use of InvalidationService (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: First set of review fixes Created 7 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/invalidation/ticl_invalidation_service.h
diff --git a/chrome/browser/invalidation/ticl_invalidation_service.h b/chrome/browser/invalidation/ticl_invalidation_service.h
index 137198aa0637341db6e55e0b9d82300b27724b7b..f504cda5353554f637e21de6358c4e7ab439628c 100644
--- a/chrome/browser/invalidation/ticl_invalidation_service.h
+++ b/chrome/browser/invalidation/ticl_invalidation_service.h
@@ -7,7 +7,7 @@
#include "base/memory/scoped_ptr.h"
#include "base/threading/non_thread_safe.h"
-#include "chrome/browser/invalidation/invalidation_frontend.h"
+#include "chrome/browser/invalidation/invalidation_service.h"
#include "chrome/browser/invalidation/invalidator_storage.h"
#include "chrome/browser/signin/signin_global_error.h"
#include "components/browser_context_keyed_service/browser_context_keyed_service.h"
@@ -24,14 +24,17 @@ namespace syncer {
class Invalidator;
}
+namespace extensions {
+class PushMessagingApiTest;
dcheng 2013/05/23 00:35:45 Ick. Can you file a bug to clean this up and assig
rlarocque 2013/05/23 21:43:27 Done. See crbug.com/243482.
+}
+
namespace invalidation {
// This InvalidationService wraps the C++ Invalidation Client (TICL) library.
// It provides invalidations for desktop platforms (Win, Mac, Linux).
class TiclInvalidationService
: public base::NonThreadSafe,
- public ProfileKeyedService,
- public InvalidationFrontend,
+ public InvalidationService,
public content::NotificationObserver,
public syncer::InvalidationHandler {
public:
@@ -42,7 +45,7 @@ class TiclInvalidationService
void Init();
- // InvalidationFrontend implementation.
+ // InvalidationService implementation.
// It is an error to have registered handlers when Shutdown() is called.
virtual void RegisterInvalidationHandler(
syncer::InvalidationHandler* handler) OVERRIDE;
@@ -55,7 +58,7 @@ class TiclInvalidationService
const invalidation::ObjectId& id,
const syncer::AckHandle& ack_handle) OVERRIDE;
virtual syncer::InvalidatorState GetInvalidatorState() const OVERRIDE;
- virtual std::string GetInvalidatorClientId() const;
+ virtual std::string GetInvalidatorClientId() const OVERRIDE;
// content::NotificationObserver implementation.
virtual void Observe(int type,
@@ -76,6 +79,7 @@ class TiclInvalidationService
void InitForTest(syncer::Invalidator* invalidator);
friend class TiclInvalidationServiceTestDelegate;
+ friend class extensions::PushMessagingApiTest;
private:
bool IsReadyToStart();

Powered by Google App Engine
This is Rietveld 408576698