third_party/WebKit/Source/web/tests/WebInputEventConversionTest.cpp - Issue 1557993002: Add scroll units in GestureEvents.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/web/tests/WebInputEventConversionTest.cpp

Issue 1557993002: Add scroll units in GestureEvents. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 12 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« third_party/WebKit/Source/core/input/EventHandler.cpp ('K') | « third_party/WebKit/Source/web/tests/VisualViewportTest.cpp ('k') | third_party/WebKit/public/web/WebInputEvent.h » ('j') | third_party/WebKit/public/web/WebInputEvent.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/web/tests/WebInputEventConversionTest.cpp

diff --git a/third_party/WebKit/Source/web/tests/WebInputEventConversionTest.cpp b/third_party/WebKit/Source/web/tests/WebInputEventConversionTest.cpp

index 51de4ed18a9e753ca3eb4c09cba289ab087cd47d..ac4caa205b6c8ee6381a588fdd8a832fbf26de6d 100644

--- a/third_party/WebKit/Source/web/tests/WebInputEventConversionTest.cpp

+++ b/third_party/WebKit/Source/web/tests/WebInputEventConversionTest.cpp

@@ -441,7 +441,7 @@ TEST(WebInputEventConversionTest, InputEventsScaling)

{

PlatformGestureEvent platformGestureEvent(PlatformEvent::GestureScrollUpdate, IntPoint(10, 12), IntPoint(20, 22), IntSize(25, 27), 0,

PlatformEvent::NoModifiers, PlatformGestureSourceTouchscreen);

- platformGestureEvent.setScrollGestureData(30, 32, 40, 42, true, true, -1 /* null plugin id */);

+ platformGestureEvent.setScrollGestureData(30, 32, ScrollByPrecisePixel, 40, 42, true, true, -1 /* null plugin id */);

// FIXME: GestureEvent does not preserve velocityX, velocityY,

// or preventPropagation. It also fails to scale

// coordinates (x, y, deltaX, deltaY) to the page scale. This