Add scroll units in GestureEvents.

Add scroll units in GestureEvents.

Allow scroll units to be conveyed on GestureEvents to allow for
page based gesture scrolls.

The struct is memset to 0; so the default is PrecisePixels (0).

BUG=568183
Committed: https://crrev.com/b1c5ecea48eacd4322a5ce3bb84f1a4acbb58cbd
Cr-Commit-Position: refs/heads/master@{#370039}

[dtapuska, 2016-01-04 22:14:00]

Description was changed from

==========
Add scroll units in GestureEvents.

Allow scroll units to be conveyed on GestureEvents to allow for
page based gesture scrolls.

The struct is memset to 0; so the default is PrecisePixels (0).

BUG=568183
==========

to

==========
Add scroll units in GestureEvents.

Allow scroll units to be conveyed on GestureEvents to allow for
page based gesture scrolls.

The struct is memset to 0; so the default is PrecisePixels (0).

BUG=568183
==========

[dtapuska, 2016-01-04 22:14:01]

dtapuska@chromium.org changed reviewers:
+ tdresser@chromium.org

[tdresser, 2016-01-05 16:07:33]

https://codereview.chromium.org/1557993002/diff/1/third_party/WebKit/Source/c...
File third_party/WebKit/Source/core/input/EventHandler.cpp (right):

https://codereview.chromium.org/1557993002/diff/1/third_party/WebKit/Source/c...
third_party/WebKit/Source/core/input/EventHandler.cpp:2514:
delta.setHeight(delta.height() > 0 ? 1 : -1);
If a mousewheel is set to scroll by page, and we coalesce multiple events
together, should we scroll multiple pages? I suspect that we should.

We might want to have a test for this case.

https://codereview.chromium.org/1557993002/diff/1/third_party/WebKit/public/w...
File third_party/WebKit/public/web/WebInputEvent.h (right):

https://codereview.chromium.org/1557993002/diff/1/third_party/WebKit/public/w...
third_party/WebKit/public/web/WebInputEvent.h:511: unsigned deltaHintUnits : 3;
It might be worth commenting that the default of 0 is PrecisePixels (and below)

[tdresser, 2016-01-05 16:27:32]

LGTM, with nit.

https://codereview.chromium.org/1557993002/diff/1/third_party/WebKit/Source/c...
File third_party/WebKit/Source/core/input/EventHandler.cpp (right):

https://codereview.chromium.org/1557993002/diff/1/third_party/WebKit/Source/c...
third_party/WebKit/Source/core/input/EventHandler.cpp:2514:
delta.setHeight(delta.height() > 0 ? 1 : -1);
On 2016/01/05 16:07:33, tdresser wrote:
> If a mousewheel is set to scroll by page, and we coalesce multiple events
> together, should we scroll multiple pages? I suspect that we should.
> 
> We might want to have a test for this case.

I didn't realize this was already the case.
Let's file a bug for this somewhere, but I don't think this is particularly high
priority.

[dtapuska, 2016-01-05 16:52:28]

https://codereview.chromium.org/1557993002/diff/1/third_party/WebKit/Source/c...
File third_party/WebKit/Source/core/input/EventHandler.cpp (right):

https://codereview.chromium.org/1557993002/diff/1/third_party/WebKit/Source/c...
third_party/WebKit/Source/core/input/EventHandler.cpp:2514:
delta.setHeight(delta.height() > 0 ? 1 : -1);
On 2016/01/05 16:07:33, tdresser wrote:
> If a mousewheel is set to scroll by page, and we coalesce multiple events
> together, should we scroll multiple pages? I suspect that we should.
> 
> We might want to have a test for this case.

Acknowledged.

https://codereview.chromium.org/1557993002/diff/1/third_party/WebKit/Source/c...
third_party/WebKit/Source/core/input/EventHandler.cpp:2514:
delta.setHeight(delta.height() > 0 ? 1 : -1);
On 2016/01/05 16:27:32, tdresser wrote:
> On 2016/01/05 16:07:33, tdresser wrote:
> > If a mousewheel is set to scroll by page, and we coalesce multiple events
> > together, should we scroll multiple pages? I suspect that we should.
> > 
> > We might want to have a test for this case.
> 
> I didn't realize this was already the case.
> Let's file a bug for this somewhere, but I don't think this is particularly
high
> priority.

I'll move it to the time the gesture is generated; that will make more sense.

https://codereview.chromium.org/1557993002/diff/1/third_party/WebKit/public/w...
File third_party/WebKit/public/web/WebInputEvent.h (right):

https://codereview.chromium.org/1557993002/diff/1/third_party/WebKit/public/w...
third_party/WebKit/public/web/WebInputEvent.h:511: unsigned deltaHintUnits : 3;
On 2016/01/05 16:07:33, tdresser wrote:
> It might be worth commenting that the default of 0 is PrecisePixels (and
below)

Done.

[dtapuska, 2016-01-05 16:53:27]

dtapuska@chromium.org changed reviewers:
+ rbyers@chromium.org

[tdresser, 2016-01-05 17:00:20]

On 2016/01/05 16:53:41, dtapuska wrote:

Still LGTM

[Rick Byers, 2016-01-08 21:54:18]

Looks good except that you should probably add a test of some sort that verifies
the difference in behavior between these three units.

/cc skobes in case he has additional feedback.

[dtapuska, 2016-01-14 18:59:11]

On 2016/01/08 21:54:18, Rick Byers wrote:
> Looks good except that you should probably add a test of some sort that
verifies
> the difference in behavior between these three units.
> 
> /cc skobes in case he has additional feedback.

Done. PTAL.

[Rick Byers, 2016-01-15 19:49:04]

LGTM

[dtapuska, 2016-01-18 18:09:14]

The CQ bit was checked by dtapuska@chromium.org

[dtapuska, 2016-01-18 18:09:15]

The patchset sent to the CQ was uploaded after l-g-t-m from
tdresser@chromium.org, rbyers@chromium.org
Link to the patchset: https://codereview.chromium.org/1557993002/#ps130001
(title: "Fix layout test on Mac")

[commit-bot: I haz the power, 2016-01-18 18:09:37]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1557993002/130001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1557993002/130001

[commit-bot: I haz the power, 2016-01-18 18:18:10]

Description was changed from

==========
Add scroll units in GestureEvents.

Allow scroll units to be conveyed on GestureEvents to allow for
page based gesture scrolls.

The struct is memset to 0; so the default is PrecisePixels (0).

BUG=568183
==========

to

==========
Add scroll units in GestureEvents.

Allow scroll units to be conveyed on GestureEvents to allow for
page based gesture scrolls.

The struct is memset to 0; so the default is PrecisePixels (0).

BUG=568183
==========

[commit-bot: I haz the power, 2016-01-18 18:18:11]

Committed patchset #8 (id:130001)

[commit-bot: I haz the power, 2016-01-18 18:19:23]

Description was changed from

==========
Add scroll units in GestureEvents.

Allow scroll units to be conveyed on GestureEvents to allow for
page based gesture scrolls.

The struct is memset to 0; so the default is PrecisePixels (0).

BUG=568183
==========

to

==========
Add scroll units in GestureEvents.

Allow scroll units to be conveyed on GestureEvents to allow for
page based gesture scrolls.

The struct is memset to 0; so the default is PrecisePixels (0).

BUG=568183

Committed: https://crrev.com/b1c5ecea48eacd4322a5ce3bb84f1a4acbb58cbd
Cr-Commit-Position: refs/heads/master@{#370039}
==========

[commit-bot: I haz the power, 2016-01-18 18:19:24]

Patchset 8 (id:??) landed as
https://crrev.com/b1c5ecea48eacd4322a5ce3bb84f1a4acbb58cbd
Cr-Commit-Position: refs/heads/master@{#370039}