Make standard input /dev/null when running xdg-settings to set the default browser.

Make standard input /dev/null when running xdg-settings to set the default browser.
BUG=17219
TEST=run chrome from a terminal in KDE and use the "set as default browser" feature when ~/.kde/share/config/profilerc is owned by root; chrome should not freeze


Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=21129

[Evan Stade, 2009-07-20 22:42:52]

nits

http://codereview.chromium.org/155796/diff/1/2
File chrome/browser/shell_integration_linux.cc (right):

http://codereview.chromium.org/155796/diff/1/2#newcode36
Line 36: base::ProcessHandle handle;
variables should be declared right where they are used, can you move handle and
no_files and success_code accordingly?

also the naming of |no_files| is a little deceptive now

[Mike Mammarella, 2009-07-20 22:52:59]

http://codereview.chromium.org/155796/diff/1/2
File chrome/browser/shell_integration_linux.cc (right):

http://codereview.chromium.org/155796/diff/1/2#newcode36
Line 36: base::ProcessHandle handle;
On 2009/07/20 22:42:53, Evan Stade wrote:
> variables should be declared right where they are used, can you move handle
and
> no_files and success_code accordingly?
> 
> also the naming of |no_files| is a little deceptive now

Done.

[Evan Stade, 2009-07-20 22:58:07]

lgtm