Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(241)

Issue 1557953002: Revert unfinished work of "full-frame-measurement" (Closed)

Created:
4 years, 11 months ago by Xianzhu
Modified:
4 years, 11 months ago
CC:
blink-reviews, chromium-reviews, telemetry-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@PerfPaint
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert unfinished work of "full-frame-measurement" I wanted to measure full-frame performance using the existing performance tests, but used a method requiring internal API of content_shell. I didn't finish the remaining work of setting up reference build of content_shell etc. Also slimiming paint will change how compositing update, paint invalidation and paint work. This CL reverts the unfinished work of "full-frame-measurement" by: - Renaming PerfTestRunner.forceLayoutOrFullFrame() to PerfTestRunner.forceLayout(); - Removing full-frame-measurement benchmarks requiring content_shell; - Removing content_shell from perf bot build. Future full-frame-measurement tests should use requestAnimationFrame(). (See third_party/WebKit/PerformanceTests/Paint/large-table*.html created by jchaffraix@ for example.) BUG=426599 R=jchaffraix@chromium.org,nednguyen@google.com TBR=wangxianzhu@chromium.org (build/all.gyp) CQ_EXTRA_TRYBOTS=tryserver.chromium.perf:linux_perf_bisect;tryserver.chromium.perf:mac_10_10_perf_bisect;tryserver.chromium.perf:win_perf_bisect Committed: https://crrev.com/5cba1e2af6c1e29afbe088413bfbf6f94d6eb0f3 Cr-Commit-Position: refs/heads/master@{#367562}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+94 lines, -141 lines) Patch
M build/all.gyp View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/PerformanceTests/Layout/ArabicLineLayout.html View 1 chunk +3 lines, -3 lines 0 comments Download
M third_party/WebKit/PerformanceTests/Layout/Shapes/MultipleShapes.html View 3 chunks +3 lines, -3 lines 0 comments Download
M third_party/WebKit/PerformanceTests/Layout/Shapes/resources/shapes.js View 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/PerformanceTests/Layout/SimpleTextPathLineLayout.html View 1 chunk +3 lines, -3 lines 0 comments Download
M third_party/WebKit/PerformanceTests/Layout/add-remove-inline-floats.html View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/PerformanceTests/Layout/auto-grid-lots-of-data.html View 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/PerformanceTests/Layout/chapter-reflow.html View 1 chunk +3 lines, -3 lines 0 comments Download
M third_party/WebKit/PerformanceTests/Layout/chapter-reflow-once.html View 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/PerformanceTests/Layout/chapter-reflow-once-random.html View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/PerformanceTests/Layout/chapter-reflow-thrice.html View 1 chunk +6 lines, -6 lines 0 comments Download
M third_party/WebKit/PerformanceTests/Layout/chapter-reflow-twice.html View 1 chunk +4 lines, -4 lines 0 comments Download
M third_party/WebKit/PerformanceTests/Layout/fixed-grid-lots-of-data.html View 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/PerformanceTests/Layout/fixed-grid-lots-of-stretched-data.html View 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/PerformanceTests/Layout/flexbox-column-nowrap.html View 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/PerformanceTests/Layout/flexbox-column-wrap.html View 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/PerformanceTests/Layout/flexbox-lots-of-data.html View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/PerformanceTests/Layout/flexbox-row-nowrap.html View 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/PerformanceTests/Layout/flexbox-row-wrap.html View 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/PerformanceTests/Layout/flexbox-with-stretch-layout.html View 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/WebKit/PerformanceTests/Layout/hindi-line-layout.html View 1 chunk +3 lines, -3 lines 0 comments Download
M third_party/WebKit/PerformanceTests/Layout/latin-complex-text.html View 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/PerformanceTests/Layout/layers_overlap_2d.html View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/PerformanceTests/Layout/layers_overlap_3d.html View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/PerformanceTests/Layout/line-layout.html View 1 chunk +3 lines, -3 lines 0 comments Download
M third_party/WebKit/PerformanceTests/Layout/line-layout-line-height.html View 1 chunk +3 lines, -3 lines 0 comments Download
M third_party/WebKit/PerformanceTests/Layout/multicol/fixed-height-with-spanner-and-nested-tables.html View 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/PerformanceTests/Layout/multicol/lots-of-text-autofill.html View 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/PerformanceTests/Layout/multicol/lots-of-text-balanced.html View 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/PerformanceTests/Layout/multicol/tall-content-short-columns.html View 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/PerformanceTests/Layout/multicol/tall-content-short-columns-realistic.html View 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/PerformanceTests/Layout/nested-blocks-with-percent-height-and-max-height.html View 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/PerformanceTests/Layout/resources/character_fallback_test.js View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/PerformanceTests/Layout/resources/floats.js View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/PerformanceTests/Layout/resources/large-table-with-collapsed-borders.js View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/PerformanceTests/Layout/subtree-detaching.html View 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/WebKit/PerformanceTests/Layout/vertical-japanese-kokoro-insert.html View 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/PerformanceTests/SVG/SvgCubics.html View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/PerformanceTests/SVG/SvgNestedUse.html View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/PerformanceTests/ShadowDOM/ChangingClassName.html View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/PerformanceTests/ShadowDOM/ChangingClassNameShadowDOM.html View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/PerformanceTests/ShadowDOM/ChangingSelect.html View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/PerformanceTests/ShadowDOM/ChangingSelectWithoutShadow.html View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/PerformanceTests/ShadowDOM/ContentReprojection.html View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/PerformanceTests/ShadowDOM/DistributionWithMultipleShadowRoots.html View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/PerformanceTests/ShadowDOM/MultipleInsertionPoints.html View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/PerformanceTests/ShadowDOM/ShadowReprojection.html View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/PerformanceTests/ShadowDOM/SmallDistributionWithLayout.html View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/PerformanceTests/ShadowDOM/shadow-style-share.html View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/PerformanceTests/ShadowDOM/shadow-style-share-attr-selectors.html View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/PerformanceTests/ShadowDOM/shadow-style-share-media-query.html View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/PerformanceTests/ShadowDOM/shadow-style-share-with-distribution.html View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/PerformanceTests/resources/runner.js View 2 chunks +2 lines, -15 lines 0 comments Download
M tools/perf/benchmarks/blink_perf.py View 3 chunks +0 lines, -33 lines 0 comments Download

Depends on Patchset:

Messages

Total messages: 21 (11 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1557953002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1557953002/1
4 years, 11 months ago (2016-01-04 18:39:23 UTC) #3
Xianzhu
Ptal: nednguyen@: tools/perf/ jchaffraix@: third_party/WebKit/PerformanceTests/
4 years, 11 months ago (2016-01-04 18:39:27 UTC) #5
nednguyen
lgtm
4 years, 11 months ago (2016-01-04 18:41:02 UTC) #6
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 11 months ago (2016-01-04 21:01:52 UTC) #8
Julien - ping for review
lgtm
4 years, 11 months ago (2016-01-05 09:26:11 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1557953002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1557953002/1
4 years, 11 months ago (2016-01-05 17:21:52 UTC) #12
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/132590)
4 years, 11 months ago (2016-01-05 17:31:38 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1557953002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1557953002/1
4 years, 11 months ago (2016-01-05 17:34:24 UTC) #17
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 11 months ago (2016-01-05 17:41:24 UTC) #19
commit-bot: I haz the power
4 years, 11 months ago (2016-01-05 17:42:37 UTC) #21
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/5cba1e2af6c1e29afbe088413bfbf6f94d6eb0f3
Cr-Commit-Position: refs/heads/master@{#367562}

Powered by Google App Engine
This is Rietveld 408576698