Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(7)

Issue 1557923003: Ensure consistency of representations when replacing integer ops with constants (Closed)

Created:
4 years, 11 months ago by Vyacheslav Egorov (Google)
Modified:
4 years, 11 months ago
Reviewers:
Florian Schneider
CC:
reviews_dartlang.org, vm-dev_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Ensure consistency of representations when replacing integer ops with constants during canonicalization. BUG=dartbug.com/25335 R=fschneider@google.com Committed: https://github.com/dart-lang/sdk/commit/c0e374d455009c8512a061e06884bb862819c3d0

Patch Set 1 #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+55 lines, -5 lines) Patch
M runtime/vm/intermediate_language.h View 1 chunk +2 lines, -0 lines 0 comments Download
M runtime/vm/intermediate_language.cc View 5 chunks +20 lines, -5 lines 0 comments Download
A tests/standalone/regress_25335_test.dart View 1 1 chunk +33 lines, -0 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
Vyacheslav Egorov (Google)
PTAL
4 years, 11 months ago (2016-01-05 14:55:49 UTC) #2
Florian Schneider
Lgtm. Please add the repro from the issue as regression test.
4 years, 11 months ago (2016-01-05 15:03:56 UTC) #3
Vyacheslav Egorov (Google)
4 years, 11 months ago (2016-01-05 16:10:35 UTC) #5
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as
c0e374d455009c8512a061e06884bb862819c3d0 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698