Issue 1557923003: Ensure consistency of representations when replacing integer ops with constants

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1557923003: Ensure consistency of representations when replacing integer ops with constants (Closed)

Created:
4 years, 11 months ago by Vyacheslav Egorov (Google)

Modified:
4 years, 11 months ago

Reviewers:
Florian Schneider

CC:
reviews_dartlang.org, vm-dev_dartlang.org

Base URL:
git@github.com:dart-lang/sdk.git@master

Target Ref:
refs/heads/master

Visibility:
Public.

Ensure consistency of representations when replacing integer ops with constants during canonicalization. BUG=dartbug.com/25335 R=fschneider@google.com Committed: https://github.com/dart-lang/sdk/commit/c0e374d455009c8512a061e06884bb862819c3d0

Created: 4 years, 11 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+55 lines, -5 lines)			Patch
M	runtime/vm/intermediate_language.h	View		1 chunk	+2 lines, -0 lines	0 comments	Download
M	runtime/vm/intermediate_language.cc	View		5 chunks	+20 lines, -5 lines	0 comments	Download
A	tests/standalone/regress_25335_test.dart	View	1	1 chunk	+33 lines, -0 lines	0 comments	Download

Total messages: 5 (2 generated)

Florian Schneider

Lgtm. Please add the repro from the issue as regression test.

4 years, 11 months ago (2016-01-05 15:03:56 UTC) #3

Vyacheslav Egorov (Google)

4 years, 11 months ago (2016-01-05 16:10:35 UTC) #5

Message was sent while issue was closed.

Committed patchset #2 (id:20001) manually as
c0e374d455009c8512a061e06884bb862819c3d0 (presubmit successful).