Fixed an assertion error in GrAAConvexTessellator. While adding a new point, it would check that th…

Fixed an assertion error in GrAAConvexTessellator. While adding a new point, it would check that the new point was not a duplicate of the previous point. It would then drop the previous point if it was in the middle of a straight line, and proceed to add the new point.

Unfortunately, floating point precision issues mean that sometimes, after dropping the previous point, we'd end up with the newly-added point as a duplicate of the new previous point, tripping an assertion failure.

BUG=skia:4732
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1557903002

Committed: https://skia.googlesource.com/skia/+/1bcbc8f8c0747691496d779055675bc47ca65c86

[ethannicholas, 2016-01-04 15:40:36]

Description was changed from

==========
Fixed an assertion error in GrAAConvexTessellator. While adding a new point, it
would check that the new point was not a duplicate of the previous point. It
would then drop the previous point if it was in the middle of a straight line,
and proceed to add the new point.

Unfortunately, floating point precision issues mean that sometimes, after
dropping the previous point, we'd end up with the newly-added point as a
duplicate of the new previous point, tripping an assertion failure.

BUG=skia:4732
==========

to

==========
Fixed an assertion error in GrAAConvexTessellator. While adding a new point, it
would check that the new point was not a duplicate of the previous point. It
would then drop the previous point if it was in the middle of a straight line,
and proceed to add the new point.

Unfortunately, floating point precision issues mean that sometimes, after
dropping the previous point, we'd end up with the newly-added point as a
duplicate of the new previous point, tripping an assertion failure.

BUG=skia:4732
GOLD_TRYBOT_URL=
https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is...
==========

[ethannicholas, 2016-01-04 15:41:07]

The CQ bit was checked by ethannicholas@google.com to run a CQ dry run

[commit-bot: I haz the power, 2016-01-04 15:41:17]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1557903002/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1557903002/1

[commit-bot: I haz the power, 2016-01-04 15:55:51]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-01-04 15:55:51]

Dry run: This issue passed the CQ dry run.

[ethannicholas, 2016-01-04 15:57:34]

Description was changed from

==========
Fixed an assertion error in GrAAConvexTessellator. While adding a new point, it
would check that the new point was not a duplicate of the previous point. It
would then drop the previous point if it was in the middle of a straight line,
and proceed to add the new point.

Unfortunately, floating point precision issues mean that sometimes, after
dropping the previous point, we'd end up with the newly-added point as a
duplicate of the new previous point, tripping an assertion failure.

BUG=skia:4732
GOLD_TRYBOT_URL=
https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is...
==========

to

==========
Fixed an assertion error in GrAAConvexTessellator. While adding a new point, it
would check that the new point was not a duplicate of the previous point. It
would then drop the previous point if it was in the middle of a straight line,
and proceed to add the new point.

Unfortunately, floating point precision issues mean that sometimes, after
dropping the previous point, we'd end up with the newly-added point as a
duplicate of the new previous point, tripping an assertion failure.

BUG=skia:4732
GOLD_TRYBOT_URL=
https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is...
==========

[ethannicholas, 2016-01-04 15:58:37]

ethannicholas@google.com changed reviewers:
+ robertphillips@google.com

[robertphillips1, 2016-01-04 16:03:19]

robertphillips@chromium.org changed reviewers:
+ robertphillips@chromium.org

[robertphillips1, 2016-01-04 16:03:19]

lgtm

[ethannicholas, 2016-01-08 21:47:43]

The CQ bit was checked by ethannicholas@google.com

[commit-bot: I haz the power, 2016-01-08 21:47:49]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1557903002/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1557903002/20001

[commit-bot: I haz the power, 2016-01-08 22:09:20]

Description was changed from

==========
Fixed an assertion error in GrAAConvexTessellator. While adding a new point, it
would check that the new point was not a duplicate of the previous point. It
would then drop the previous point if it was in the middle of a straight line,
and proceed to add the new point.

Unfortunately, floating point precision issues mean that sometimes, after
dropping the previous point, we'd end up with the newly-added point as a
duplicate of the new previous point, tripping an assertion failure.

BUG=skia:4732
GOLD_TRYBOT_URL=
https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is...
==========

to

==========
Fixed an assertion error in GrAAConvexTessellator. While adding a new point, it
would check that the new point was not a duplicate of the previous point. It
would then drop the previous point if it was in the middle of a straight line,
and proceed to add the new point.

Unfortunately, floating point precision issues mean that sometimes, after
dropping the previous point, we'd end up with the newly-added point as a
duplicate of the new previous point, tripping an assertion failure.

BUG=skia:4732
GOLD_TRYBOT_URL=
https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is...

Committed:
https://skia.googlesource.com/skia/+/1bcbc8f8c0747691496d779055675bc47ca65c86
==========

[commit-bot: I haz the power, 2016-01-08 22:09:21]

Committed patchset #2 (id:20001) as
https://skia.googlesource.com/skia/+/1bcbc8f8c0747691496d779055675bc47ca65c86