Issue 155790: Properly collapse newlines (and leading/trailing whitespace) from pasted...

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 155790: Properly collapse newlines (and leading/trailing whitespace) from pasted... (Closed)

Created:
11 years, 5 months ago by viettrungluu-gmail

Modified:
9 years, 7 months ago

Reviewers:
Nico

CC:
chromium-reviews_googlegroups.com, John Grabowski, Ben Goodger (Google)

Base URL:
http://src.chromium.org/svn/trunk/src/

Visibility:
Public.

Description

Properly collapse newlines (and leading/trailing whitespace) from pasted text in location bar. E.g., pasting www.foo. org/ bar into an empty location bar should yield "www.foo.org/bar". To accomplish this (as of Patch Set 3), in AutocompleteTextFieldEditor we override NSTextView's -paste:pboard: method, and manually read the pasteboard, collapse, and insert the text. As long as all pastes occur through this method, it'll be fine. Patch Set 4: unit test added. BUG=14577 TEST=chrome/browser/cocoa/autocomplete_text_field_editor_unittest.mm

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+68 lines, -4 lines)			Patch
MM	chrome/browser/cocoa/autocomplete_text_field_editor.h	View		1 chunk	+5 lines, -0 lines	0 comments	Download
M	chrome/browser/cocoa/autocomplete_text_field_editor.mm	View	1 2	2 chunks	+19 lines, -4 lines	0 comments	Download
MM	chrome/browser/cocoa/autocomplete_text_field_editor_unittest.mm	View		3 chunks	+44 lines, -0 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Nico

This looks similar to http://codereview.chromium.org/159018 .

11 years, 5 months ago (2009-07-21 17:18:19 UTC) #1

viettrungluu-gmail

11 years, 5 months ago (2009-07-21 17:34:08 UTC) #2

On 2009/07/21 17:18:19, thakis wrote:
> This looks similar to http://codereview.chromium.org/159018 .

Right. Seeing as how that patch is more thorough, I'll withdraw mine.

Expand Messages | Collapse Messages

Issue 155790: Properly collapse newlines (and leading/trailing whitespace) from pasted... (Closed)

Description

Patch Set 1 #

Patch Set 2 : '' #

Patch Set 3 : '' #

Patch Set 4 : '' #

Messages