Optimized TurboFan support for rest args.

Optimized TurboFan support for rest args.

R=bmeurer@chromium.org
BUG=

Committed: https://crrev.com/c89ddbb7bc5d4c8d158685dfcc21c2b17ee4a282
Cr-Commit-Position: refs/heads/master@{#33105}

[mvstanton, 2016-01-04 15:19:38]

Hi Benedikt, here is the optimized support we discussed.

Note that I have a todo in there crying about the fact that we need a
SharedFunctionInfo in order to pick up the strong mode info. But I propose to
follow up by removing this strong mode argument from the stub, along with the
todo.

Heck, I'll prepare that in parallel.
Thanks,
--Mike

[Benedikt Meurer, 2016-01-04 19:57:53]

https://codereview.chromium.org/1557883002/diff/1/src/compiler/js-typed-lower...
File src/compiler/js-typed-lowering.cc (right):

https://codereview.chromium.org/1557883002/diff/1/src/compiler/js-typed-lower...
src/compiler/js-typed-lowering.cc:1652: // whether
Nit: comment wrapped somehow

https://codereview.chromium.org/1557883002/diff/1/src/compiler/js-typed-lower...
src/compiler/js-typed-lowering.cc:1663: javascript()->LoadContext(0,
Context::NATIVE_CONTEXT_INDEX, true),
We drop the effect of the LoadContext on the floor, which is bad for load
elimination and probably also for escape analysis. You need to thread through
the effect instead.

https://codereview.chromium.org/1557883002/diff/1/src/compiler/js-typed-lower...
src/compiler/js-typed-lowering.cc:1665: Node* const load_jsarray_map =
graph()->NewNode(
We drop the effect of the LoadContext on the floor, which is bad for load
elimination and probably also for escape analysis. You need to thread through
the effect instead.

[mvstanton, 2016-01-05 09:18:23]

Thanks for the comments! Addressed, and some unit tests.

https://codereview.chromium.org/1557883002/diff/1/src/compiler/js-typed-lower...
File src/compiler/js-typed-lowering.cc (right):

https://codereview.chromium.org/1557883002/diff/1/src/compiler/js-typed-lower...
src/compiler/js-typed-lowering.cc:1652: // whether
On 2016/01/04 19:57:52, Benedikt Meurer wrote:
> Nit: comment wrapped somehow

Done.

https://codereview.chromium.org/1557883002/diff/1/src/compiler/js-typed-lower...
src/compiler/js-typed-lowering.cc:1663: javascript()->LoadContext(0,
Context::NATIVE_CONTEXT_INDEX, true),
On 2016/01/04 19:57:52, Benedikt Meurer wrote:
> We drop the effect of the LoadContext on the floor, which is bad for load
> elimination and probably also for escape analysis. You need to thread through
> the effect instead.

Done.

https://codereview.chromium.org/1557883002/diff/1/src/compiler/js-typed-lower...
src/compiler/js-typed-lowering.cc:1665: Node* const load_jsarray_map =
graph()->NewNode(
On 2016/01/04 19:57:52, Benedikt Meurer wrote:
> We drop the effect of the LoadContext on the floor, which is bad for load
> elimination and probably also for escape analysis. You need to thread through
> the effect instead.

Done.

[Benedikt Meurer, 2016-01-05 09:18:54]

Thanks. LGTM.

[mvstanton, 2016-01-05 09:22:49]

The CQ bit was checked by mvstanton@chromium.org

[commit-bot: I haz the power, 2016-01-05 09:23:00]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1557883002/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1557883002/20001

[commit-bot: I haz the power, 2016-01-05 09:40:13]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-01-05 09:40:46]

Description was changed from

==========
Optimized TurboFan support for rest args.

R=bmeurer@chromium.org
BUG=
==========

to

==========
Optimized TurboFan support for rest args.

R=bmeurer@chromium.org
BUG=

Committed: https://crrev.com/c89ddbb7bc5d4c8d158685dfcc21c2b17ee4a282
Cr-Commit-Position: refs/heads/master@{#33105}
==========

[commit-bot: I haz the power, 2016-01-05 09:40:47]

Patchset 2 (id:??) landed as
https://crrev.com/c89ddbb7bc5d4c8d158685dfcc21c2b17ee4a282
Cr-Commit-Position: refs/heads/master@{#33105}