Issue 155785: File dropped off a popup CL

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 155785: File dropped off a popup CL (Closed)

Created:
11 years, 5 months ago by John Grabowski

Modified:
9 years, 6 months ago

Reviewers:
Scott Hess - ex-Googler

CC:
chromium-reviews_googlegroups.com, John Grabowski, Ben Goodger (Google)

Base URL:
svn://chrome-svn/chrome/trunk/src/

Visibility:
Public.

Description

File dropped off a popup CL :-( TEST=A few things. Bookmark bar test (16063): - open bookmark bar, then open popup. Popup should not have bmb. - close bookmark bar, then open popup. Popup should not have bmb. - In main window, toggle bmb a few times. Popup should not change. Tab at bottom bug (16329): - Open 'details' popup in gmail (next to 'last acct activity') - make sure no tab strip at the bottom of the window General (15727): - Open a popup. Make sure no toolbar (back/fwd buttons et al) Test: same as listed in Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=21110

Patch Set 1 #

Created: 11 years, 5 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+30 lines, -24 lines)			Patch
	M	chrome/browser/cocoa/browser_window_controller.mm	View		4 chunks	+30 lines, -24 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

John Grabowski

File fell off http://codereview.chromium.org/155444

11 years, 5 months ago (2009-07-20 18:17:10 UTC) #1

Scott Hess - ex-Googler

11 years, 5 months ago (2009-07-20 19:59:02 UTC) #2

On 2009/07/20 18:17:10, John Grabowski wrote:
> File fell off http://codereview.chromium.org/155444

LGTM.

Expand Messages | Collapse Messages