chrome/android/java/src/org/chromium/chrome/browser/customtabs/CustomTabContentHandler.java - Issue 1557803002: [Custom Tabs] Implement Bottombar

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/customtabs/CustomTabContentHandler.java

Issue 1557803002: [Custom Tabs] Implement Bottombar (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: respond to dfalcantara@'s comments Created 4 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/android/java/src/org/chromium/chrome/browser/customtabs/CustomTabActivity.java ('k') | chrome/android/java/src/org/chromium/chrome/browser/customtabs/CustomTabIntentDataProvider.java » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/android/java/src/org/chromium/chrome/browser/customtabs/CustomTabContentHandler.java

diff --git a/chrome/android/java/src/org/chromium/chrome/browser/customtabs/CustomTabContentHandler.java b/chrome/android/java/src/org/chromium/chrome/browser/customtabs/CustomTabContentHandler.java

index 9a952d5234072fadafcc320967bb8475a9b0215d..9ff458738ff6943ee17a8ec80fdee397b948af41 100644

--- a/chrome/android/java/src/org/chromium/chrome/browser/customtabs/CustomTabContentHandler.java

+++ b/chrome/android/java/src/org/chromium/chrome/browser/customtabs/CustomTabContentHandler.java

@@ -38,8 +38,8 @@ public interface CustomTabContentHandler {

boolean shouldIgnoreIntent(Intent intent);

/**

- * Updates the content of custom action button shown on the toolbar.

+ * Finds the action button with the given id, and updates it with the new content.

* @return Whether the action button has been updated.

- boolean updateActionButton(Bitmap bitmap, String description);

+ boolean updateCustomButton(int id, Bitmap bitmap, String description);

}