chrome/android/java/src/org/chromium/chrome/browser/customtabs/CustomTabsConnection.java - Issue 1557803002: [Custom Tabs] Implement Bottombar

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/customtabs/CustomTabsConnection.java

Issue 1557803002: [Custom Tabs] Implement Bottombar (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 12 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/android/java/src/org/chromium/chrome/browser/customtabs/BottombarItemParams.java ('K') | « chrome/android/java/src/org/chromium/chrome/browser/customtabs/CustomTabIntentDataProvider.java ('k') | chrome/android/java/src/org/chromium/chrome/browser/enhancedbookmarks/EnhancedBookmarkContentView.java » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/android/java/src/org/chromium/chrome/browser/customtabs/CustomTabsConnection.java

diff --git a/chrome/android/java/src/org/chromium/chrome/browser/customtabs/CustomTabsConnection.java b/chrome/android/java/src/org/chromium/chrome/browser/customtabs/CustomTabsConnection.java

index f06e3a61af860f9fb7d425d3c683fa548ca1a90b..8d92fc3f2f64b0eb0926dde5e1d11d589a2aa22d 100644

--- a/chrome/android/java/src/org/chromium/chrome/browser/customtabs/CustomTabsConnection.java

+++ b/chrome/android/java/src/org/chromium/chrome/browser/customtabs/CustomTabsConnection.java

@@ -371,13 +371,14 @@ public class CustomTabsConnection extends ICustomTabsService.Stub {

@Override

public boolean updateVisuals(final ICustomTabsCallback callback, Bundle bundle) {

+ // TODO(ianwen): add update logic for bottom bar items.

final Bundle actionButtonBundle = IntentUtils.safeGetBundle(bundle,

CustomTabsIntent.EXTRA_ACTION_BUTTON_BUNDLE);

if (actionButtonBundle == null) return false;

- final Bitmap bitmap = ActionButtonParams.tryParseBitmapFromBundle(mApplication,

+ final Bitmap bitmap = ButtonParams.tryParseBitmapFromBundle(mApplication,

actionButtonBundle);

- final String description = ActionButtonParams

+ final String description = ButtonParams

.tryParseDescriptionFromBundle(actionButtonBundle);

if (bitmap == null || description == null) return false;