Fix assumption in mojo binding class Connector that message pipes notice the other end's closing sy…

Fix assumption in mojo binding class Connector that message pipes notice the other end's closing synchronously.

This was causing mojo_public_bindings_unittests' MultiplexRouterTest.BasicRequestResponse and MultiplexRouterTest.RequestWithNoReceiver to fail with the new EDK. The problem is that in Connector::HandleError message_pipe_ is reset to a dummy message pipe whose other end is closed immediately. In the old EDK, the live end notices that the peer is closed synchronously. In the new EDK this happens asynchronously because of thread hops to the IO thread. The fix is to simply ensure we don't watch the message pipe handle twice (since it's not cancelled immediately).

BUG=561803
Committed: https://crrev.com/b0c8bd36ad840b609050caee081fa73e0e212559
Cr-Commit-Position: refs/heads/master@{#367327}

[jam, 2015-12-31 19:33:25]

Description was changed from

==========
Fix assumption in mojo binding class Connector that message pipes notice the
other end's closing synchronously.

This was causing mojo_public_bindings_unittests'
MultiplexRouterTest.BasicRequestResponse and
MultiplexRouterTest.RequestWithNoReceiver to fail with the new EDK. The problem
is that in Connector::HandleError message_pipe_ is reset to a dummy message pipe
whose other end is closed immediately. In the old EDK, the live end notices that
the peer is closed synchronously. In the new EDK this happens asynchronously
because of thread hops to the IO thread. The fix is to simply ensure we don't
watch the message pipe handle twice (since it's not cancelled immediately).

BUG=561803
==========

to

==========
Fix assumption in mojo binding class Connector that message pipes notice the
other end's closing synchronously.

This was causing mojo_public_bindings_unittests'
MultiplexRouterTest.BasicRequestResponse and
MultiplexRouterTest.RequestWithNoReceiver to fail with the new EDK. The problem
is that in Connector::HandleError message_pipe_ is reset to a dummy message pipe
whose other end is closed immediately. In the old EDK, the live end notices that
the peer is closed synchronously. In the new EDK this happens asynchronously
because of thread hops to the IO thread. The fix is to simply ensure we don't
watch the message pipe handle twice (since it's not cancelled immediately).

BUG=561803
==========

[jam, 2015-12-31 19:33:25]

jam@chromium.org changed reviewers:
+ yzshen@chromium.org

[jam, 2016-01-04 15:20:47]

Patchset #1 (id:1) has been deleted

[yzshen1, 2016-01-04 18:08:10]

LGTM

[jam, 2016-01-04 18:09:19]

The CQ bit was checked by jam@chromium.org

[commit-bot: I haz the power, 2016-01-04 18:10:34]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1557753002/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1557753002/20001

[commit-bot: I haz the power, 2016-01-04 18:16:23]

Description was changed from

==========
Fix assumption in mojo binding class Connector that message pipes notice the
other end's closing synchronously.

This was causing mojo_public_bindings_unittests'
MultiplexRouterTest.BasicRequestResponse and
MultiplexRouterTest.RequestWithNoReceiver to fail with the new EDK. The problem
is that in Connector::HandleError message_pipe_ is reset to a dummy message pipe
whose other end is closed immediately. In the old EDK, the live end notices that
the peer is closed synchronously. In the new EDK this happens asynchronously
because of thread hops to the IO thread. The fix is to simply ensure we don't
watch the message pipe handle twice (since it's not cancelled immediately).

BUG=561803
==========

to

==========
Fix assumption in mojo binding class Connector that message pipes notice the
other end's closing synchronously.

This was causing mojo_public_bindings_unittests'
MultiplexRouterTest.BasicRequestResponse and
MultiplexRouterTest.RequestWithNoReceiver to fail with the new EDK. The problem
is that in Connector::HandleError message_pipe_ is reset to a dummy message pipe
whose other end is closed immediately. In the old EDK, the live end notices that
the peer is closed synchronously. In the new EDK this happens asynchronously
because of thread hops to the IO thread. The fix is to simply ensure we don't
watch the message pipe handle twice (since it's not cancelled immediately).

BUG=561803
==========

[commit-bot: I haz the power, 2016-01-04 18:16:24]

Committed patchset #1 (id:20001)

[commit-bot: I haz the power, 2016-01-04 18:17:10]

Description was changed from

==========
Fix assumption in mojo binding class Connector that message pipes notice the
other end's closing synchronously.

This was causing mojo_public_bindings_unittests'
MultiplexRouterTest.BasicRequestResponse and
MultiplexRouterTest.RequestWithNoReceiver to fail with the new EDK. The problem
is that in Connector::HandleError message_pipe_ is reset to a dummy message pipe
whose other end is closed immediately. In the old EDK, the live end notices that
the peer is closed synchronously. In the new EDK this happens asynchronously
because of thread hops to the IO thread. The fix is to simply ensure we don't
watch the message pipe handle twice (since it's not cancelled immediately).

BUG=561803
==========

to

==========
Fix assumption in mojo binding class Connector that message pipes notice the
other end's closing synchronously.

This was causing mojo_public_bindings_unittests'
MultiplexRouterTest.BasicRequestResponse and
MultiplexRouterTest.RequestWithNoReceiver to fail with the new EDK. The problem
is that in Connector::HandleError message_pipe_ is reset to a dummy message pipe
whose other end is closed immediately. In the old EDK, the live end notices that
the peer is closed synchronously. In the new EDK this happens asynchronously
because of thread hops to the IO thread. The fix is to simply ensure we don't
watch the message pipe handle twice (since it's not cancelled immediately).

BUG=561803

Committed: https://crrev.com/b0c8bd36ad840b609050caee081fa73e0e212559
Cr-Commit-Position: refs/heads/master@{#367327}
==========

[commit-bot: I haz the power, 2016-01-04 18:17:11]

Patchset 1 (id:??) landed as
https://crrev.com/b0c8bd36ad840b609050caee081fa73e0e212559
Cr-Commit-Position: refs/heads/master@{#367327}