Two malloc+bzero -> calloc.

Two malloc+bzero -> calloc.

I was profiling DM and noticed a couple spots where we malloc then bzero.
These might as well call calloc instead:
   - any time DM itself allocates bitmaps for raster drawing;
   - any time Skia allocates memory for a raster SkSurface.

We could use malloc for opaque surfaces, but it seems simpler to always calloc.

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1557713003

Committed: https://skia.googlesource.com/skia/+/c8be09aaf2bbfa004c574553fc9d194ac7f1ce1a

[mtklein_C, 2015-12-31 06:10:10]

Description was changed from

==========
Two malloc+bzero -> calloc.

I was profiling DM and noticed a couple new spots where we malloc then bzero.
These might as well call calloc instead:
   - any time DM itself allocates bitmaps for raster drawing;
   - any time Skia allocates memory for a raster SkSurface.

We could use malloc for opaque surfaces, but it seems simpler to always calloc.

BUG=skia:
==========

to

==========
Two malloc+bzero -> calloc.

I was profiling DM and noticed a couple new spots where we malloc then bzero.
These might as well call calloc instead:
   - any time DM itself allocates bitmaps for raster drawing;
   - any time Skia allocates memory for a raster SkSurface.

We could use malloc for opaque surfaces, but it seems simpler to always calloc.

BUG=skia:
GOLD_TRYBOT_URL=
https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is...
==========

[mtklein_C, 2015-12-31 06:12:43]

Description was changed from

==========
Two malloc+bzero -> calloc.

I was profiling DM and noticed a couple new spots where we malloc then bzero.
These might as well call calloc instead:
   - any time DM itself allocates bitmaps for raster drawing;
   - any time Skia allocates memory for a raster SkSurface.

We could use malloc for opaque surfaces, but it seems simpler to always calloc.

BUG=skia:
GOLD_TRYBOT_URL=
https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is...
==========

to

==========
Two malloc+bzero -> calloc.

I was profiling DM and noticed a couple spots where we malloc then bzero.
These might as well call calloc instead:
   - any time DM itself allocates bitmaps for raster drawing;
   - any time Skia allocates memory for a raster SkSurface.

We could use malloc for opaque surfaces, but it seems simpler to always calloc.

BUG=skia:
GOLD_TRYBOT_URL=
https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is...
==========

[mtklein_C, 2015-12-31 06:13:13]

The CQ bit was checked by mtklein@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2015-12-31 06:13:20]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1557713003/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1557713003/1

[commit-bot: I haz the power, 2015-12-31 06:28:49]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-12-31 06:28:50]

Dry run: This issue passed the CQ dry run.

[mtklein_C, 2015-12-31 07:27:18]

mtklein@chromium.org changed reviewers:
+ reed@google.com

[reed1, 2015-12-31 13:17:49]

https://codereview.chromium.org/1557713003/diff/1/src/image/SkSurface_Raster.cpp
File src/image/SkSurface_Raster.cpp (right):

https://codereview.chromium.org/1557713003/diff/1/src/image/SkSurface_Raster....
src/image/SkSurface_Raster.cpp:171: return new SkSurface_Raster(info, pixels,
rb, releaseProc, context, props);
When the constructor is called from here, do we know that the caller has zeroed
the pixels?

[mtklein, 2015-12-31 21:35:46]

mtklein@google.com changed reviewers:
+ mtklein@google.com

[mtklein, 2015-12-31 21:35:47]

https://codereview.chromium.org/1557713003/diff/1/src/image/SkSurface_Raster.cpp
File src/image/SkSurface_Raster.cpp (right):

https://codereview.chromium.org/1557713003/diff/1/src/image/SkSurface_Raster....
src/image/SkSurface_Raster.cpp:171: return new SkSurface_Raster(info, pixels,
rb, releaseProc, context, props);
On 2015/12/31 13:17:49, reed1 wrote:
> When the constructor is called from here, do we know that the caller has
zeroed
> the pixels?

There are two constructors.  This CL only changes the 2-argument constructor
used below when we own the pixels.
It does not change the 6-argument constructor used here for unowned pixels
(which has never zeroed the pixels).

[reed1, 2016-01-04 15:04:22]

You're right, and in fact, the new (2) constructors are clearly more parallel
than before, as now neither fiddles with the pixel memory.

LGTM!

[mtklein, 2016-01-05 02:37:39]

The CQ bit was checked by mtklein@google.com

[commit-bot: I haz the power, 2016-01-05 02:37:56]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1557713003/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1557713003/1

[commit-bot: I haz the power, 2016-01-05 02:56:59]

Description was changed from

==========
Two malloc+bzero -> calloc.

I was profiling DM and noticed a couple spots where we malloc then bzero.
These might as well call calloc instead:
   - any time DM itself allocates bitmaps for raster drawing;
   - any time Skia allocates memory for a raster SkSurface.

We could use malloc for opaque surfaces, but it seems simpler to always calloc.

BUG=skia:
GOLD_TRYBOT_URL=
https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is...
==========

to

==========
Two malloc+bzero -> calloc.

I was profiling DM and noticed a couple spots where we malloc then bzero.
These might as well call calloc instead:
   - any time DM itself allocates bitmaps for raster drawing;
   - any time Skia allocates memory for a raster SkSurface.

We could use malloc for opaque surfaces, but it seems simpler to always calloc.

BUG=skia:
GOLD_TRYBOT_URL=
https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is...

Committed:
https://skia.googlesource.com/skia/+/c8be09aaf2bbfa004c574553fc9d194ac7f1ce1a
==========

[commit-bot: I haz the power, 2016-01-05 02:57:00]

Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/c8be09aaf2bbfa004c574553fc9d194ac7f1ce1a