Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(372)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1557683002: Convert Pass()→std::move() in //ui (CrOS edition) (Closed)

Created:
4 years, 11 months ago by dcheng
Modified:
4 years, 11 months ago
Reviewers:
Avi (use Gerrit)
CC:
chromium-apps-reviews_chromium.org, chromium-reviews, extensions-reviews_chromium.org, mlamouri+watch-notifications_chromium.org, nona+watch_chromium.org, oshima+watch_chromium.org, Peter Beverloo, shuchen+watch_chromium.org, James Su, yusukes+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Convert Pass()→std::move() in //ui (CrOS edition) (╯^□^)╯︵ ❄☃❄ BUG=557422 R=avi@chromium.org Committed: https://crrev.com/023d488b047379f778fccae7e436dd246dc42cdb Cr-Commit-Position: refs/heads/master@{#367229}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+50 lines, -36 lines) Patch
M ui/base/ime/chromeos/component_extension_ime_manager.cc View 2 chunks +2 lines, -1 line 0 comments Download
M ui/base/ime/chromeos/input_method_whitelist.cc View 1 chunk +1 line, -1 line 0 comments Download
M ui/chromeos/touch_exploration_controller.cc View 9 chunks +10 lines, -8 lines 0 comments Download
M ui/display/chromeos/apply_content_protection_task_unittest.cc View 8 chunks +10 lines, -8 lines 0 comments Download
M ui/display/chromeos/display_configurator.cc View 2 chunks +2 lines, -1 line 0 comments Download
M ui/display/chromeos/query_content_protection_task_unittest.cc View 9 chunks +11 lines, -9 lines 0 comments Download
M ui/display/chromeos/test/test_display_layout_manager.cc View 2 chunks +3 lines, -1 line 0 comments Download
M ui/display/chromeos/update_display_configuration_task_unittest.cc View 3 chunks +4 lines, -2 lines 0 comments Download
M ui/display/chromeos/x11/native_display_event_dispatcher_x11.cc View 2 chunks +6 lines, -4 lines 0 comments Download
M ui/message_center/message_center_tray_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 13 (6 generated)
dcheng
4 years, 11 months ago (2015-12-31 00:58:22 UTC) #3
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1557683002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1557683002/1
4 years, 11 months ago (2015-12-31 00:59:41 UTC) #5
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 11 months ago (2015-12-31 01:32:23 UTC) #7
Avi (use Gerrit)
lgtm stampity stamp
4 years, 11 months ago (2015-12-31 04:49:14 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1557683002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1557683002/1
4 years, 11 months ago (2015-12-31 04:50:34 UTC) #10
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 11 months ago (2015-12-31 04:55:22 UTC) #11
commit-bot: I haz the power
4 years, 11 months ago (2015-12-31 04:56:14 UTC) #13
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/023d488b047379f778fccae7e436dd246dc42cdb
Cr-Commit-Position: refs/heads/master@{#367229}

Powered by Google App Engine
This is Rietveld 408576698