Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(160)

Issue 1557673002: js_runtime: streamline stringReplaceAllUnchecked (Closed)

Created:
4 years, 11 months ago by sra1
Modified:
4 years, 11 months ago
Reviewers:
floitsch
CC:
reviews_dartlang.org
Base URL:
https://github.com/dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 : #

Patch Set 2 : fix #

Unified diffs Side-by-side diffs Delta from patch set Stats (+18 lines, -5 lines) Patch
M sdk/lib/_internal/js_runtime/lib/js_helper.dart View 1 1 chunk +1 line, -2 lines 0 comments Download
M sdk/lib/_internal/js_runtime/lib/string_helper.dart View 1 2 chunks +7 lines, -3 lines 0 comments Download
M tests/corelib/string_replace_all_test.dart View 1 chunk +10 lines, -0 lines 0 comments Download

Messages

Total messages: 11 (5 generated)
sra1
4 years, 11 months ago (2015-12-30 23:17:15 UTC) #3
floitsch
LGTM.
4 years, 11 months ago (2016-01-04 10:42:17 UTC) #4
sra1
Committed patchset #1 (id:20001) manually as be1b32207bc1c1f610c2e96f32c9c6ca37fa0259 (presubmit successful).
4 years, 11 months ago (2016-01-04 16:26:13 UTC) #6
sra1
PTAL
4 years, 11 months ago (2016-01-04 18:18:40 UTC) #8
floitsch
LGTM.
4 years, 11 months ago (2016-01-05 09:24:18 UTC) #9
sra1
4 years, 11 months ago (2016-01-05 21:37:39 UTC) #11
Message was sent while issue was closed.
Committed patchset #2 (id:40001) manually as
4fc394c96dea1749e3139161ac9a928a206473f6 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698