Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(124)

Issue 1557643002: Fix net_unittests build errors when enable_bidirectional_stream is set. (Closed)

Created:
4 years, 11 months ago by mef
Modified:
4 years, 11 months ago
Reviewers:
Nico, luqui
CC:
chromium-reviews, cbentzel+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix net_unittests build errors when enable_bidirectional_stream is set. 1. Use int instead of int64. 2. Define ENABLE_BIDIRECTIONAL_STREAM on net_unittests target. BUG=516342 Committed: https://crrev.com/e666e9a71d427a7c3efdc39b1aed8ea5cba844d4 Cr-Commit-Position: refs/heads/master@{#367205}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -2 lines) Patch
M net/net.gyp View 1 chunk +5 lines, -1 line 0 comments Download
M net/spdy/bidirectional_stream_spdy_job.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 12 (5 generated)
mef
PTAL, this fixes build errors reported on official cronet builders.
4 years, 11 months ago (2015-12-30 22:31:30 UTC) #3
mef
On 2015/12/30 22:31:30, mef wrote: > PTAL, this fixes build errors reported on official cronet ...
4 years, 11 months ago (2015-12-30 22:34:09 UTC) #4
Nico
lgtm to get your bots green, but https://codereview.chromium.org/1550843002/ seems like a structurally better fix
4 years, 11 months ago (2015-12-30 22:36:44 UTC) #5
mef
On 2015/12/30 22:36:44, Nico wrote: > lgtm to get your bots green, but https://codereview.chromium.org/1550843002/ > ...
4 years, 11 months ago (2015-12-30 23:15:35 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1557643002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1557643002/1
4 years, 11 months ago (2015-12-30 23:16:48 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 11 months ago (2015-12-30 23:41:37 UTC) #10
commit-bot: I haz the power
4 years, 11 months ago (2015-12-30 23:43:01 UTC) #12
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/e666e9a71d427a7c3efdc39b1aed8ea5cba844d4
Cr-Commit-Position: refs/heads/master@{#367205}

Powered by Google App Engine
This is Rietveld 408576698