Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(245)

Issue 1557623002: Port //base/android/jni_generator/jni_generator.gyp to GN (Closed)

Created:
4 years, 11 months ago by agrieve
Modified:
4 years, 11 months ago
Reviewers:
Nico
CC:
chromium-reviews, vmpstr+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Port //base/android/jni_generator/jni_generator.gyp to GN BUG=573259, 573250 Committed: https://crrev.com/ea362d37baa7f297ddafebe7efc2171233a0b97f Cr-Commit-Position: refs/heads/master@{#367189}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+71 lines, -4 lines) Patch
M base/BUILD.gn View 1 chunk +1 line, -0 lines 0 comments Download
A base/android/jni_generator/BUILD.gn View 1 chunk +57 lines, -0 lines 0 comments Download
M base/android/jni_generator/jni_generator.gyp View 4 chunks +4 lines, -0 lines 0 comments Download
M base/android/jni_generator/sample_for_tests.cc View 5 chunks +9 lines, -4 lines 0 comments Download

Depends on Patchset:

Messages

Total messages: 12 (5 generated)
agrieve
changes to the .cc were required to get it to compile due to unused warnings
4 years, 11 months ago (2015-12-30 20:10:55 UTC) #2
Nico
lgtm Neat, I went with suppressing the warning instead: https://codereview.chromium.org/1551753002/ I'll undo my .gyp change ...
4 years, 11 months ago (2015-12-30 20:21:41 UTC) #3
Nico
(i would click cq, but the "depends on patchset" line frightens and confuses me)
4 years, 11 months ago (2015-12-30 20:45:20 UTC) #5
agrieve
On 2015/12/30 20:45:20, Nico wrote: > (i would click cq, but the "depends on patchset" ...
4 years, 11 months ago (2015-12-30 21:00:07 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1557623002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1557623002/1
4 years, 11 months ago (2015-12-30 21:00:43 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 11 months ago (2015-12-30 21:54:21 UTC) #10
commit-bot: I haz the power
4 years, 11 months ago (2015-12-30 21:55:01 UTC) #12
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/ea362d37baa7f297ddafebe7efc2171233a0b97f
Cr-Commit-Position: refs/heads/master@{#367189}

Powered by Google App Engine
This is Rietveld 408576698