Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(9)

Issue 155758: "Prepatch" for issue 13713 (resize tabstrip upon resizing window on... (Closed)

Created:
11 years, 5 months ago by viettrungluu-gmail
Modified:
9 years, 7 months ago
Reviewers:
CC:
chromium-reviews_googlegroups.com, John Grabowski, Ben Goodger (Google)
Visibility:
Public.

Description

Superseded by CL 159346: http://codereview.chromium.org/159346 "Prepatch" for issue 13713 (resize tabstrip upon resizing window on Mac). It's a "prepatch" since part of the code is obviously rubbish (see below); otherwise it seems to work fine. This just entails getting the TabStripController's TabStripView to post notifications, and the TabStripControlller to receive them (and when it does, it re-lays-out the tabs). The rubbish: We need an unanimated version of -layoutTabs (in TabStripController). I've actually split the current one into three: two public interfaces, -layoutTabs and -layoutTabsFast, and an internal one, -layoutTabsInternal. -layoutTabsInternal is currently the world's quickest and ugliest cut-and-paste job (from the old -layoutTabs), and is just there to show that things work, before someone produces a proper version. (For the unanimated version, I just excised parts which mentioned animation, and didn't bother to understand the code. I didn't want to rewrite the layout code, since I think it's currently being worked on by pinkerton.) Patch Set 3: Haven't cleared any rubbish yet -- just tracking the current version. Hopefully this patch set will hold up better to merges. BUG=13713 TEST=make lots of tabs and resize window; watch tab strip adapt

Patch Set 1 #

Patch Set 2 : '' #

Patch Set 3 : '' #

Unified diffs Side-by-side diffs Delta from patch set Stats (+163 lines, -1 line) Patch
M chrome/browser/cocoa/tab_strip_controller.h View 1 2 1 chunk +2 lines, -0 lines 0 comments Download
M chrome/browser/cocoa/tab_strip_controller.mm View 1 2 4 chunks +161 lines, -1 line 0 comments Download

Powered by Google App Engine
This is Rietveld 408576698