chrome/browser/resources/pdf/elements/viewer-page-selector/viewer-page-selector.js - Issue 1557563002: Fix for overlapping of cursor with page number in page selector.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/resources/pdf/elements/viewer-page-selector/viewer-page-selector.js

Issue 1557563002: Fix for overlapping of cursor with page number in page selector. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Changes as per review comments. Created 4 years, 12 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/resources/pdf/elements/viewer-page-selector/viewer-page-selector.css ('K') | « chrome/browser/resources/pdf/elements/viewer-page-selector/viewer-page-selector.css ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/resources/pdf/elements/viewer-page-selector/viewer-page-selector.js

diff --git a/chrome/browser/resources/pdf/elements/viewer-page-selector/viewer-page-selector.js b/chrome/browser/resources/pdf/elements/viewer-page-selector/viewer-page-selector.js

index 75a83300a9b90a3f44ebc2f18bcc4a1a678fbd4b..8b04c8c65f148428f5ee584624e8974c944bff6b 100644

--- a/chrome/browser/resources/pdf/elements/viewer-page-selector/viewer-page-selector.js

+++ b/chrome/browser/resources/pdf/elements/viewer-page-selector/viewer-page-selector.js

@@ -38,7 +38,8 @@ Polymer({

docLengthChanged: function() {

var numDigits = this.docLength.toString().length;

- this.$.pageselector.style.width = numDigits + 'ch';

+ // Increasing the width of pageselector by 1 'ch' for cursor.

+ this.$.pageselector.style.width = numDigits + 1 + 'ch';

// Set both sides of the slash to the same width, so that the layout is

// exactly centered.

this.$['pagelength-spacer'].style.width = numDigits + 'ch';

tsergeant 2016/01/06 01:58:59 Any changes to line 42 need to be made here as wel

Deepak 2016/01/06 07:35:35 Done.