Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(54)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1557553002: Global conversion of Pass()→std::move() on OS=android (Closed)

Created:
4 years, 11 months ago by dcheng
Modified:
4 years, 11 months ago
Reviewers:
Avi (use Gerrit), jam
CC:
Aaron Boodman, abarth-chromium, ben+mojo_chromium.org, cbentzel+watch_chromium.org, chromium-reviews, darin (slow to review), qsr+mojo_chromium.org, tdresser+watch_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Global conversion of Pass()→std::move() on OS=android (╯^□^)╯︵ ❄☃❄ BUG=557422 R=avi@chromium.org TBR=jam@chromium.org Committed: https://crrev.com/4de264fefd402143d2f4874ae51e601001ff80f6 Cr-Commit-Position: refs/heads/master@{#367133}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+23 lines, -22 lines) Patch
M mojo/edk/embedder/simple_platform_shared_buffer_android.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M net/android/keystore_openssl.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M net/socket/ssl_client_socket_openssl_unittest.cc View 3 chunks +7 lines, -10 lines 0 comments Download
M net/ssl/ssl_platform_key_android.cc View 4 chunks +4 lines, -3 lines 0 comments Download
M net/test/spawned_test_server/spawner_communicator.cc View 2 chunks +2 lines, -1 line 0 comments Download
M third_party/mojo/src/mojo/edk/embedder/simple_platform_shared_buffer_android.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M ui/events/gestures/blink/web_gesture_curve_impl.cc View 1 chunk +1 line, -1 line 0 comments Download
M ui/snapshot/snapshot_android.cc View 2 chunks +3 lines, -1 line 0 comments Download

Messages

Total messages: 11 (4 generated)
dcheng
+avi for general review / sanity check +jam for OWNERS stamp
4 years, 11 months ago (2015-12-30 00:23:07 UTC) #1
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1557553002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1557553002/1
4 years, 11 months ago (2015-12-30 00:26:11 UTC) #3
Avi (use Gerrit)
lgtm stampity stamp
4 years, 11 months ago (2015-12-30 00:29:32 UTC) #4
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 11 months ago (2015-12-30 01:59:01 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1557553002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1557553002/1
4 years, 11 months ago (2015-12-30 02:03:18 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 11 months ago (2015-12-30 02:07:36 UTC) #9
commit-bot: I haz the power
4 years, 11 months ago (2015-12-30 02:08:39 UTC) #11
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/4de264fefd402143d2f4874ae51e601001ff80f6
Cr-Commit-Position: refs/heads/master@{#367133}

Powered by Google App Engine
This is Rietveld 408576698