Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(430)

Issue 1557473002: Revert of Fix bootstraps_deps of tools/perf to include build/android/pylib/. (Closed)

Created:
4 years, 11 months ago by fmeawad
Modified:
4 years, 11 months ago
Reviewers:
nednguyen, llozano
CC:
chromium-reviews, telemetry-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Fix bootstraps_deps of tools/perf to include build/android/pylib/. (patchset #1 id:2 of https://codereview.chromium.org/1556463002/ ) Reason for revert: Speculative revert: Failed power benchmarks on N5 See https://code.google.com/p/chromium/issues/detail?id=572954 for details. BUG=572954 Original issue's description: > Fix bootstraps_deps of tools/perf to include build/android/pylib/. > > After John's work in crbug.com/560559, telemetry project no longer depends > on pylib, hence tools/perf which is a user of telemetry must specify this > deps explictly. > > BUG=572700, 560559 > TBR=jbudorick@chromium.org > > Committed: https://crrev.com/89fe15bf1183cd781a6d27983e7ce792f4641e88 > Cr-Commit-Position: refs/heads/master@{#367045} TBR=llozano@chromium.org,nednguyen@google.com NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=572700, 560559 Committed: https://crrev.com/5fc45b53137022c58150279fb62a0c2ef18bff80 Cr-Commit-Position: refs/heads/master@{#367088}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -2 lines) Patch
M tools/perf/bootstrap_deps View 1 chunk +0 lines, -2 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
fmeawad
Created Revert of Fix bootstraps_deps of tools/perf to include build/android/pylib/.
4 years, 11 months ago (2015-12-29 19:06:03 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1557473002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1557473002/1
4 years, 11 months ago (2015-12-29 19:06:31 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 11 months ago (2015-12-29 19:07:34 UTC) #4
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/5fc45b53137022c58150279fb62a0c2ef18bff80 Cr-Commit-Position: refs/heads/master@{#367088}
4 years, 11 months ago (2015-12-29 19:08:48 UTC) #6
fmeawad
4 years, 11 months ago (2015-12-29 19:11:23 UTC) #7
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/1550313002/ by fmeawad@chromium.org.

The reason for reverting is: Sorry I do not think this is the culprit CL
anymore, relanding..

Powered by Google App Engine
This is Rietveld 408576698