Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(760)

Issue 1557423002: Revert of Remove some dead PDF code. (Closed)

Created:
4 years, 11 months ago by Lei Zhang
Modified:
4 years, 11 months ago
Reviewers:
raymes
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Remove some dead PDF code. (patchset #3 id:40001 of https://codereview.chromium.org/1552833003/ ) Reason for revert: Causes a crash. BUG=574440 Original issue's description: > Remove some dead PDF code. > > Committed: https://crrev.com/e2cb8a125d8079f85c16290ee761460cf54b9ec4 > Cr-Commit-Position: refs/heads/master@{#367398} TBR=raymes@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true Committed: https://crrev.com/a9650644c1ea100dbde61b9c5f2fad57a82733cf Cr-Commit-Position: refs/heads/master@{#367570}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+50 lines, -3 lines) Patch
M pdf/pdf_engine.h View 3 chunks +5 lines, -0 lines 0 comments Download
M pdf/pdfium/pdfium_engine.h View 2 chunks +7 lines, -0 lines 0 comments Download
M pdf/pdfium/pdfium_engine.cc View 5 chunks +38 lines, -3 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
Lei Zhang
Created Revert of Remove some dead PDF code.
4 years, 11 months ago (2016-01-05 17:55:26 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1557423002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1557423002/1
4 years, 11 months ago (2016-01-05 17:56:56 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 11 months ago (2016-01-05 17:58:36 UTC) #4
commit-bot: I haz the power
4 years, 11 months ago (2016-01-05 17:59:43 UTC) #6
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/a9650644c1ea100dbde61b9c5f2fad57a82733cf
Cr-Commit-Position: refs/heads/master@{#367570}

Powered by Google App Engine
This is Rietveld 408576698