Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(12)

Issue 1557373002: Simplify arguments to logical[Left,Right]OffsetForPositioningFloat (Closed)

Created:
4 years, 11 months ago by davve
Modified:
4 years, 11 months ago
CC:
chromium-reviews, szager+layoutwatch_chromium.org, zoltan1, blink-reviews-layout_chromium.org, pdr+renderingwatchlist_chromium.org, eae+blinkwatch, leviw+renderwatch, jchaffraix+rendering, blink-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Simplify arguments to logical[Left,Right]OffsetForPositioningFloat |applyTextIndent=false| is always passed to logical[Left,Right]OffsetForPositioningFloat(). Might as well remove the parameter and pass |false| where it's needed. No functional change expected. Committed: https://crrev.com/a4231e4994a90b513122bdb9a58069d26938849f Cr-Commit-Position: refs/heads/master@{#367792}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -12 lines) Patch
M third_party/WebKit/Source/core/layout/LayoutBlockFlow.h View 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/layout/LayoutBlockFlow.cpp View 3 chunks +10 lines, -10 lines 0 comments Download

Messages

Total messages: 15 (8 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1557373002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1557373002/1
4 years, 11 months ago (2016-01-05 12:52:45 UTC) #2
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 11 months ago (2016-01-05 15:27:00 UTC) #5
davve
Upon reading some text indent code today I noticed this might be worthwhile simplification. Getting ...
4 years, 11 months ago (2016-01-05 16:00:34 UTC) #7
rune
Mechanical LGTM
4 years, 11 months ago (2016-01-05 16:25:43 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1557373002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1557373002/1
4 years, 11 months ago (2016-01-06 07:29:50 UTC) #11
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 11 months ago (2016-01-06 07:34:12 UTC) #13
commit-bot: I haz the power
4 years, 11 months ago (2016-01-06 07:35:16 UTC) #15
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/a4231e4994a90b513122bdb9a58069d26938849f
Cr-Commit-Position: refs/heads/master@{#367792}

Powered by Google App Engine
This is Rietveld 408576698