Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(334)

Issue 1557323003: Revert of MD Downloads: add a JS unit test for search term splitting (Closed)

Created:
4 years, 11 months ago by PEConn
Modified:
4 years, 11 months ago
CC:
arv+watch_chromium.org, chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@new-dl-data
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of MD Downloads: add a JS unit test for search term splitting (patchset #13 id:240001 of https://codereview.chromium.org/1491773002/ ) Reason for revert: I believe this change to be causing issue 574354. Original issue's description: > MD Downloads: add a JS unit test for search term splitting > > R=dpapad@chromium.org > BUG=563357 > > Committed: https://crrev.com/7ef0874d0f06cab6555b10b4be4eee8c8bff7f7d > Cr-Commit-Position: refs/heads/master@{#367461} TBR=dpapad@chromium.org,maruel@chromium.org,brettw@chromium.org,dbeam@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=563357, 574354 Committed: https://crrev.com/dd67bf44adf02bce242eaaf230d709a1493d5076 Cr-Commit-Position: refs/heads/master@{#367520}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+21 lines, -61 lines) Patch
D chrome/browser/resources/md_downloads/action_service_unittest.gtestjs View 1 chunk +0 lines, -39 lines 0 comments Download
M chrome/chrome_tests_unit.gypi View 5 chunks +8 lines, -16 lines 0 comments Download
M chrome/test/BUILD.gn View 1 chunk +7 lines, -5 lines 0 comments Download
M chrome/unit_tests.isolate View 2 chunks +6 lines, -1 line 0 comments Download

Messages

Total messages: 14 (7 generated)
PEConn
Created Revert of MD Downloads: add a JS unit test for search term splitting
4 years, 11 months ago (2016-01-05 13:36:15 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1557323003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1557323003/1
4 years, 11 months ago (2016-01-05 13:36:41 UTC) #2
commit-bot: I haz the power
No L-G-T-M from a valid reviewer yet. Only full committers are accepted. Even if an ...
4 years, 11 months ago (2016-01-05 13:36:45 UTC) #4
Bernhard Bauer
lgtm
4 years, 11 months ago (2016-01-05 13:50:42 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1557323003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1557323003/1
4 years, 11 months ago (2016-01-05 13:51:55 UTC) #10
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 11 months ago (2016-01-05 13:52:54 UTC) #12
commit-bot: I haz the power
4 years, 11 months ago (2016-01-05 13:53:46 UTC) #14
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/dd67bf44adf02bce242eaaf230d709a1493d5076
Cr-Commit-Position: refs/heads/master@{#367520}

Powered by Google App Engine
This is Rietveld 408576698