chrome/browser/extensions/activity_log/activity_log_unittest.cc - Issue 15573003: New architecture of the activity logging: Policies for summarization (and compression)

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/activity_log/activity_log_unittest.cc

Issue 15573003: New architecture of the activity logging: Policies for summarization (and compression) (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Adressed Matt and Adrienne's comments. Created 7 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/extensions/activity_log/activity_log_policy.cc ('k') | chrome/browser/extensions/activity_log/fullstream_ui_policy.h » ('j') | chrome/browser/extensions/activity_log/fullstream_ui_policy.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/extensions/activity_log/activity_log_unittest.cc

diff --git a/chrome/browser/extensions/activity_log/activity_log_unittest.cc b/chrome/browser/extensions/activity_log/activity_log_unittest.cc

index 3c7dadc1b484873fbaf0b45f5528f25b920a18f8..3174803e68a34c5a649d6bb48192f1837d0a4155 100644

--- a/chrome/browser/extensions/activity_log/activity_log_unittest.cc

+++ b/chrome/browser/extensions/activity_log/activity_log_unittest.cc

@@ -204,7 +204,7 @@ TEST_F(ActivityLogTest, LogWithoutArguments) {

ActivityLog* activity_log = ActivityLog::GetInstance(profile_.get());

activity_log->SetArgumentLoggingForTesting(false);

ASSERT_TRUE(activity_log->IsLogEnabled());

+ activity_log->SetDefaultPolicy(ActivityLogPolicy::POLICY_NOARGS);

scoped_ptr<ListValue> args(new ListValue());

args->Set(0, new base::StringValue("hello"));

args->Set(1, new base::StringValue("world"));

@@ -216,6 +216,7 @@ TEST_F(ActivityLogTest, LogWithoutArguments) {

TEST_F(ActivityLogTest, LogWithArguments) {

ActivityLog* activity_log = ActivityLog::GetInstance(profile_.get());

+ activity_log->SetDefaultPolicy(ActivityLogPolicy::POLICY_FULLSTREAM);

ASSERT_TRUE(activity_log->IsLogEnabled());

scoped_ptr<ListValue> args(new ListValue());

@@ -239,6 +240,7 @@ TEST_F(RenderViewActivityLogTest, LogPrerender) {

.Build();

extension_service_->AddExtension(extension.get());

ActivityLog* activity_log = ActivityLog::GetInstance(profile());

+ activity_log->SetDefaultPolicy(ActivityLogPolicy::POLICY_FULLSTREAM);

ASSERT_TRUE(activity_log->IsLogEnabled());

GURL url("http://www.google.com");