Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(45)

Issue 1557283002: X87: Use register arguments for RestParamAccessStub. (Closed)

Created:
4 years, 11 months ago by zhengxing.li
Modified:
4 years, 11 months ago
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

X87: Use register arguments for RestParamAccessStub. port 82ca2a414deb4221100562a0fb2af0f216c4c3ef(r33084) original commit message: This is preferable because in TurboFan we need to call it, and can't pass untagged external pointers on the stack. BUG= Committed: https://crrev.com/050b79234e6ab52e5b64e9afb6b09e51900f244d Cr-Commit-Position: refs/heads/master@{#33102}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+27 lines, -14 lines) Patch
M src/full-codegen/x87/full-codegen-x87.cc View 1 chunk +8 lines, -5 lines 0 comments Download
M src/x87/code-stubs-x87.cc View 1 chunk +14 lines, -9 lines 0 comments Download
M src/x87/interface-descriptors-x87.cc View 1 chunk +5 lines, -0 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
zhengxing.li
PTAL, thanks!
4 years, 11 months ago (2016-01-05 03:22:42 UTC) #2
Weiliang
lgtm
4 years, 11 months ago (2016-01-05 03:44:58 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1557283002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1557283002/1
4 years, 11 months ago (2016-01-05 03:45:03 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 11 months ago (2016-01-05 04:04:29 UTC) #6
commit-bot: I haz the power
4 years, 11 months ago (2016-01-05 04:04:45 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/050b79234e6ab52e5b64e9afb6b09e51900f244d
Cr-Commit-Position: refs/heads/master@{#33102}

Powered by Google App Engine
This is Rietveld 408576698