Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(61)

Side by Side Diff: tools/clang/rewrite_to_chrome_style/tests/methods-original.cc

Issue 1557243002: Update rewrite_to_chrome_style tool to also rename methods. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Add constant test case Created 4 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
(Empty)
1 // Copyright 2015 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file.
4
5 namespace blink {
6
7 class Task {
8 public:
9 // Already style-compliant methods shouldn't change.
10 void OutputDebugString() {}
11
12 // Tests that the declarations for methods are updated.
13 void doTheWork();
14 virtual void reallyDoTheWork() = 0;
15
16 // Note: this is purposely copyable and assignable, to make sure the Clang
17 // tool doesn't try to emit replacements for things that aren't explicitly
18 // written.
19 // TODO(dcheng): Add an explicit test for something like operator+.
20 };
21
22 // Test that the actual method definition is also updated.
23 void Task::doTheWork() {
24 reallyDoTheWork();
25 }
26
27 } // namespace blink
28
29 namespace Moo {
30
31 // Test that overrides from outside the Blink namespace are also updated.
32 class BovineTask : public blink::Task {
33 public:
34 void reallyDoTheWork() override;
35 };
36
37 void BovineTask::reallyDoTheWork() {
38 doTheWork();
39 // Calls via an overridden method should also be updated.
40 reallyDoTheWork();
41 }
42
43 // Finally, test that method pointers are also updated.
44 void F() {
45 void (blink::Task::*p1)() = &blink::Task::doTheWork;
46 void (blink::Task::*p2)() = &BovineTask::doTheWork;
47 void (blink::Task::*p3)() = &blink::Task::reallyDoTheWork;
48 void (BovineTask::*p4)() = &BovineTask::reallyDoTheWork;
49 }
50
51 } // namespace Moo
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698