components/cronet/tools/generate_javadoc.py - Issue 1557233003: Download doclava when building for Android and use to build cronet Javadocs

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/cronet/tools/generate_javadoc.py

Issue 1557233003: Download doclava when building for Android and use to build cronet Javadocs (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: revert back to Patch Set 10 Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: components/cronet/tools/generate_javadoc.py

diff --git a/components/cronet/tools/generate_javadoc.py b/components/cronet/tools/generate_javadoc.py

index 4c13c03f48bc10c192d3852af3a3c207ff975c2e..cab68014a5069d2b27ee3e31a55b8fc2d4d9df9a 100755

--- a/components/cronet/tools/generate_javadoc.py

+++ b/components/cronet/tools/generate_javadoc.py

@@ -43,7 +43,7 @@ def GenerateJavadoc(options):

'-Dlib.java.dir=' + lib_java_dir, '-Doverview=' + overview_file,

'doc']

stdout = build_utils.CheckOutput(javadoc_cmd, cwd=working_dir)

- if " error: " in stdout or "warning" in stdout:

+ if " error: " in stdout or "warning" in stdout or "javadoc: error " in stdout:

build_utils.DeleteDirectory(output_dir)

raise build_utils.CalledProcessError(working_dir, javadoc_cmd, stdout)

« no previous file with comments | « components/cronet/android/api/src/org/chromium/net/UrlRequest.java ('k') | no next file » | no next file with comments »