Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(373)

Unified Diff: src/a64/macro-assembler-a64.cc

Issue 155723005: A64: Synchronize with r19001. (Closed) Base URL: https://v8.googlecode.com/svn/branches/experimental/a64
Patch Set: Created 6 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « src/a64/macro-assembler-a64.h ('k') | src/a64/simulator-a64.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/a64/macro-assembler-a64.cc
diff --git a/src/a64/macro-assembler-a64.cc b/src/a64/macro-assembler-a64.cc
index 84269cf6f07b6cc21fdb20655577feb273d837fc..8ea5498a4bf285b1bc2e415a277ddecd6273bfac 100644
--- a/src/a64/macro-assembler-a64.cc
+++ b/src/a64/macro-assembler-a64.cc
@@ -1323,7 +1323,6 @@ static int AddressOffset(ExternalReference ref0, ExternalReference ref1) {
void MacroAssembler::CallApiFunctionAndReturn(
Register function_address,
ExternalReference thunk_ref,
- Register thunk_last_arg,
int stack_space,
int spill_offset,
MemOperand return_value_operand,
@@ -1339,14 +1338,10 @@ void MacroAssembler::CallApiFunctionAndReturn(
ExternalReference::handle_scope_level_address(isolate()),
next_address);
- ASSERT(function_address.Is(x3));
- ASSERT(!AreAliased(function_address, thunk_last_arg, x1, x2));
+ ASSERT(!AreAliased(function_address, x1, x2));
// TODO(all): Why do we care about aliasing x2? (This function uses x1 as a
// scratch regiser.)
- // TODO(all): Why isn't thunk_last_arg used?
- USE(thunk_last_arg);
-
Label profiler_disabled;
Label end_profiler_check;
bool* is_profiling_flag = isolate()->cpu_profiler()->is_profiling_address();
@@ -1357,13 +1352,15 @@ void MacroAssembler::CallApiFunctionAndReturn(
// Additional parameter is the address of the actual callback.
Mov(function_address, Operand(thunk_ref));
- // TODO(jbramley): Remove this once the no-op move at profiler_disabled is
- // investigated.
- B(&end_profiler_check);
-
- Bind(&profiler_disabled);
- // TODO(jbramley): ARM does a no-op move here. Why?
- Bind(&end_profiler_check);
+ if (!function_address.Is(x3)) {
+ B(&end_profiler_check);
+ Bind(&profiler_disabled);
+ Mov(x3, function_address);
+ Bind(&end_profiler_check);
+ } else {
+ Bind(&profiler_disabled);
+ Bind(&end_profiler_check);
+ }
// Save the callee-save registers we are going to use.
// TODO(all): Is this necessary? ARM doesn't do it.
« no previous file with comments | « src/a64/macro-assembler-a64.h ('k') | src/a64/simulator-a64.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698