Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(673)

Issue 155723004: A64: Add support for --deopt-every-n-times for n != 2 (Closed)

Created:
6 years, 10 months ago by jochen (gone - plz use gerrit)
Modified:
6 years, 10 months ago
CC:
v8-dev
Visibility:
Public.

Description

A64: Add support for --deopt-every-n-times for n != 2 To match arm, the DeoptimizeIf*() methods need to invoke the DeoptimizeHeader() method explicitly, so we do the check even if the condition does not hold. BUG=none R=ulan@chromium.org, rodolph.perfetta@arm.com LOG=n Committed: https://code.google.com/p/v8/source/detail?r=19235

Patch Set 1 #

Total comments: 1

Patch Set 2 : updates #

Total comments: 2

Patch Set 3 : updates #

Patch Set 4 : updates #

Unified diffs Side-by-side diffs Delta from patch set Stats (+17 lines, -8 lines) Patch
M src/a64/lithium-codegen-a64.cc View 1 2 3 2 chunks +17 lines, -8 lines 0 comments Download

Messages

Total messages: 8 (0 generated)
jochen (gone - plz use gerrit)
6 years, 10 months ago (2014-02-10 14:27:38 UTC) #1
jochen (gone - plz use gerrit)
PTAL https://codereview.chromium.org/155723004/diff/1/src/a64/lithium-codegen-a64.cc File src/a64/lithium-codegen-a64.cc (right): https://codereview.chromium.org/155723004/diff/1/src/a64/lithium-codegen-a64.cc#newcode974 src/a64/lithium-codegen-a64.cc:974: return false; It doesn't really matter what we ...
6 years, 10 months ago (2014-02-10 14:32:07 UTC) #2
jochen (gone - plz use gerrit)
disregard my comment... updated
6 years, 10 months ago (2014-02-10 14:49:44 UTC) #3
ulan
https://codereview.chromium.org/155723004/diff/60001/src/a64/lithium-codegen-a64.cc File src/a64/lithium-codegen-a64.cc (right): https://codereview.chromium.org/155723004/diff/60001/src/a64/lithium-codegen-a64.cc#newcode973 src/a64/lithium-codegen-a64.cc:973: __ Call(entry, RelocInfo::RUNTIME_ENTRY); This works only if (frame_is_built_ && ...
6 years, 10 months ago (2014-02-10 15:21:40 UTC) #4
jochen (gone - plz use gerrit)
https://codereview.chromium.org/155723004/diff/60001/src/a64/lithium-codegen-a64.cc File src/a64/lithium-codegen-a64.cc (right): https://codereview.chromium.org/155723004/diff/60001/src/a64/lithium-codegen-a64.cc#newcode973 src/a64/lithium-codegen-a64.cc:973: __ Call(entry, RelocInfo::RUNTIME_ENTRY); On 2014/02/10 15:21:40, ulan wrote: > ...
6 years, 10 months ago (2014-02-10 16:05:58 UTC) #5
jochen (gone - plz use gerrit)
added ASSERT(frame_is_built_);
6 years, 10 months ago (2014-02-10 16:07:50 UTC) #6
ulan
lgtm
6 years, 10 months ago (2014-02-10 16:12:53 UTC) #7
jochen (gone - plz use gerrit)
6 years, 10 months ago (2014-02-10 16:34:08 UTC) #8
Message was sent while issue was closed.
Committed patchset #4 manually as r19235 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698