Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(181)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1557173002: Add FPDFDoc_GetPageMode() embeddertest (Closed)

Created:
4 years, 11 months ago by Tom Sepez
Modified:
4 years, 11 months ago
Reviewers:
Lei Zhang
CC:
pdfium-reviews_googlegroups.com
Base URL:
https://pdfium.googlesource.com/pdfium.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Total comments: 6

Patch Set 2 : nits #

Unified diffs Side-by-side diffs Delta from patch set Stats (+34 lines, -6 lines) Patch
M BUILD.gn View 1 chunk +1 line, -0 lines 0 comments Download
A fpdfsdk/src/fpdfext_embeddertest.cpp View 1 1 chunk +24 lines, -0 lines 0 comments Download
M pdfium.gyp View 1 chunk +1 line, -0 lines 0 comments Download
A + testing/resources/use_outlines.in View 1 chunk +1 line, -0 lines 0 comments Download
A + testing/resources/use_outlines.pdf View 2 chunks +7 lines, -6 lines 0 comments Download

Messages

Total messages: 5 (1 generated)
Tom Sepez
Lei, for review.
4 years, 11 months ago (2016-01-04 22:48:57 UTC) #1
Lei Zhang
lgtm https://codereview.chromium.org/1557173002/diff/1/fpdfsdk/src/fpdfext_embeddertest.cpp File fpdfsdk/src/fpdfext_embeddertest.cpp (right): https://codereview.chromium.org/1557173002/diff/1/fpdfsdk/src/fpdfext_embeddertest.cpp#newcode1 fpdfsdk/src/fpdfext_embeddertest.cpp:1: // Copyright 20155 PDFium Authors. All rights reserved. ...
4 years, 11 months ago (2016-01-04 23:00:29 UTC) #2
Tom Sepez
https://codereview.chromium.org/1557173002/diff/1/fpdfsdk/src/fpdfext_embeddertest.cpp File fpdfsdk/src/fpdfext_embeddertest.cpp (right): https://codereview.chromium.org/1557173002/diff/1/fpdfsdk/src/fpdfext_embeddertest.cpp#newcode1 fpdfsdk/src/fpdfext_embeddertest.cpp:1: // Copyright 20155 PDFium Authors. All rights reserved. On ...
4 years, 11 months ago (2016-01-04 23:03:25 UTC) #3
Tom Sepez
4 years, 11 months ago (2016-01-04 23:03:51 UTC) #5
Message was sent while issue was closed. 
Committed patchset #2 (id:20001) manually as
14fdb1d40741912e430db4318a9033764429659f (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698