Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(153)

Issue 1557123002: remove now defunct get_paint_offset (Closed)

Created:
4 years, 11 months ago by reed1
Modified:
4 years, 11 months ago
Reviewers:
mtklein, robertphillips
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

remove now defunct get_paint_offset This used to be used when we wanted to know where the paint was, so we could perform peep-hole optimizations. We no longer do that on this (older) picture format, so now this function only serves to clog up the file with asserts. BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1557123002 Committed: https://skia.googlesource.com/skia/+/512f3e3b2592097a39bde9331829b38d16c0f85d

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -122 lines) Patch
M src/core/SkPictureRecord.cpp View 25 chunks +1 line, -122 lines 0 comments Download

Messages

Total messages: 12 (7 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1557123002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1557123002/1
4 years, 11 months ago (2016-01-04 21:51:08 UTC) #3
reed1
4 years, 11 months ago (2016-01-04 21:52:20 UTC) #6
robertphillips
lgtm
4 years, 11 months ago (2016-01-04 22:05:07 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1557123002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1557123002/1
4 years, 11 months ago (2016-01-04 22:10:48 UTC) #10
commit-bot: I haz the power
4 years, 11 months ago (2016-01-04 22:11:34 UTC) #12
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/512f3e3b2592097a39bde9331829b38d16c0f85d

Powered by Google App Engine
This is Rietveld 408576698