Make _incremental usable by instrumentation tests

Make _incremental usable by instrumentation tests

E.g. chrome_public_apk_incremental can now be used when running
chrome_public_apk_tests.

This does not yet add support for making chrome_public_apk_tests itself
use incremental packaging.

BUG=567724
Committed: https://crrev.com/4d8f9b1632e9fd508bef00ec34b572604e8c6ede
Cr-Commit-Position: refs/heads/master@{#367909}

[agrieve, 2016-01-04 21:24:39]

Description was changed from

==========
Make _incremental usable by instrumentation tests

E.g. chrome_public_apk_incremental can now be used when running
chrome_public_apk_tests.

This does not yet add support for making chrome_public_apk_tests itself
use incremental packaging.

BUG=567724
==========

to

==========
Make _incremental usable by instrumentation tests

E.g. chrome_public_apk_incremental can now be used when running
chrome_public_apk_tests.

This does not yet add support for making chrome_public_apk_tests itself
use incremental packaging.

BUG=567724
==========

[agrieve, 2016-01-04 21:24:39]

agrieve@chromium.org changed reviewers:
+ dgn@chromium.org

[agrieve, 2016-01-04 21:24:55]

On 2016/01/04 21:24:39, agrieve wrote:
> mailto:agrieve@chromium.org changed reviewers:
> + mailto:dgn@chromium.org

₪₪

[dgn, 2016-01-06 16:55:46]

On 2016/01/04 21:24:55, agrieve wrote:
> On 2016/01/04 21:24:39, agrieve wrote:
> > mailto:agrieve@chromium.org changed reviewers:
> > + mailto:dgn@chromium.org
> 
> ₪₪

So, if I understand correctly, this is just a fix for the NPE. But is it
expected that the value is null in the first place? Where/when is that real name
supposed to be set? only in the test apk?

[agrieve, 2016-01-06 18:32:40]

On 2016/01/06 16:55:46, dgn wrote:
> On 2016/01/04 21:24:55, agrieve wrote:
> > On 2016/01/04 21:24:39, agrieve wrote:
> > > mailto:agrieve@chromium.org changed reviewers:
> > > + mailto:dgn@chromium.org
> > 
> > ₪₪
> 
> So, if I understand correctly, this is just a fix for the NPE. But is it
> expected that the value is null in the first place? Where/when is that real
name
> supposed to be set? only in the test apk?

I've update the code comments to better explain the two cases (as well as
figuring it out for myself :P)

[dgn, 2016-01-06 20:46:09]

thanks! lgtm

https://codereview.chromium.org/1557103002/diff/20001/build/android/increment...
File
build/android/incremental_install/java/org/chromium/incrementalinstall/BootstrapApplication.java
(right):

https://codereview.chromium.org/1557103002/diff/20001/build/android/increment...
build/android/incremental_install/java/org/chromium/incrementalinstall/BootstrapApplication.java:137:
// it exists within the test apk (as apposed to the incremental apk-under-test).
s/as apposed/as opposed/ ?

[agrieve, 2016-01-06 20:50:58]

https://codereview.chromium.org/1557103002/diff/20001/build/android/increment...
File
build/android/incremental_install/java/org/chromium/incrementalinstall/BootstrapApplication.java
(right):

https://codereview.chromium.org/1557103002/diff/20001/build/android/increment...
build/android/incremental_install/java/org/chromium/incrementalinstall/BootstrapApplication.java:137:
// it exists within the test apk (as apposed to the incremental apk-under-test).
On 2016/01/06 20:46:09, dgn wrote:
> s/as apposed/as opposed/ ?

Done.

[agrieve, 2016-01-06 20:51:01]

The CQ bit was checked by agrieve@chromium.org

[agrieve, 2016-01-06 20:51:02]

The patchset sent to the CQ was uploaded after l-g-t-m from dgn@chromium.org
Link to the patchset: https://codereview.chromium.org/1557103002/#ps40001
(title: "apposed -> opposed")

[commit-bot: I haz the power, 2016-01-06 20:51:27]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1557103002/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1557103002/40001

[commit-bot: I haz the power, 2016-01-06 21:12:57]

Description was changed from

==========
Make _incremental usable by instrumentation tests

E.g. chrome_public_apk_incremental can now be used when running
chrome_public_apk_tests.

This does not yet add support for making chrome_public_apk_tests itself
use incremental packaging.

BUG=567724
==========

to

==========
Make _incremental usable by instrumentation tests

E.g. chrome_public_apk_incremental can now be used when running
chrome_public_apk_tests.

This does not yet add support for making chrome_public_apk_tests itself
use incremental packaging.

BUG=567724
==========

[commit-bot: I haz the power, 2016-01-06 21:12:58]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2016-01-06 21:13:47]

Description was changed from

==========
Make _incremental usable by instrumentation tests

E.g. chrome_public_apk_incremental can now be used when running
chrome_public_apk_tests.

This does not yet add support for making chrome_public_apk_tests itself
use incremental packaging.

BUG=567724
==========

to

==========
Make _incremental usable by instrumentation tests

E.g. chrome_public_apk_incremental can now be used when running
chrome_public_apk_tests.

This does not yet add support for making chrome_public_apk_tests itself
use incremental packaging.

BUG=567724

Committed: https://crrev.com/4d8f9b1632e9fd508bef00ec34b572604e8c6ede
Cr-Commit-Position: refs/heads/master@{#367909}
==========

[commit-bot: I haz the power, 2016-01-06 21:13:49]

Patchset 3 (id:??) landed as
https://crrev.com/4d8f9b1632e9fd508bef00ec34b572604e8c6ede
Cr-Commit-Position: refs/heads/master@{#367909}