Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(277)

Unified Diff: tools/win/split_link/split_link.py

Issue 15571002: override for ignoring data exports during split link (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 7 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/win/split_link/split_link.py
diff --git a/tools/win/split_link/split_link.py b/tools/win/split_link/split_link.py
index ee70c0efdecaa50bf12812b6e5561cfb42264a42..9b050b3ff376e2762a9925e70ef0edfcc70f2cfa 100644
--- a/tools/win/split_link/split_link.py
+++ b/tools/win/split_link/split_link.py
@@ -19,6 +19,12 @@ import tempfile
BASE_DIR = os.path.dirname(os.path.abspath(__file__))
+# This can be set to ignore data exports. The resulting DLLs will probably not
+# run, but at least they can be generated. The log of data exports will still
+# be output.
+IGNORE_DATA = 0
+
+
def Log(message):
print 'split_link:', message
@@ -237,8 +243,9 @@ def GenerateDefFiles(unresolved_by_part):
for j, part in enumerate(unresolved_by_part):
if i == j:
continue
- is_data = [' DATA' if IsDataDefinition(export) else ''
- for export in part]
+ is_data = \
+ [' DATA' if IsDataDefinition(export) and not IGNORE_DATA else ''
+ for export in part]
print >> f, '\n'.join(' ' + export + data
for export, data in zip(part, is_data))
deffiles.append(deffile)
@@ -378,7 +385,7 @@ def main():
deffiles = GenerateDefFiles(unresolved_by_part)
import_libs = BuildImportLibs(flags, inputs_by_part, deffiles)
else:
- if data_exports:
+ if data_exports and not IGNORE_DATA:
print '%d data exports found, see report above.' % data_exports
print('These cannot be exported, and must be either duplicated to the '
'target DLL (if constant), or wrapped in a function.')
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698