Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(109)

Issues Search
    My Issues | Starred     Open | Closed | All

Side by Side Diff: test/mjsunit/regress/regress-crbug-422858.js

Issue 1557053002: Accept time zones like GMT-8 in the legacy date parser (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Created 4 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « src/dateparser-inl.h ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
(Empty)
1 // Copyright 2015 the V8 project authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file.
4
5 var date = new Date("2016/01/02 10:00 GMT-8")
6 assertEquals(0, date.getMinutes());
jungshik at Google 2016/01/04 20:05:08 Would it be a good idea to check hours as well ?
Dan Ehrenberg 2016/01/04 23:03:53 Good point; done
7
8 date = new Date("2016/01/02 10:00 GMT-12")
9 assertEquals(0, date.getMinutes());
10
11 date = new Date("2016/01/02 10:00 GMT-123")
12 assertEquals(23, date.getMinutes());
13
14 date = new Date("2016/01/02 10:00 GMT-0856")
15 assertEquals(56, date.getMinutes());
16
17 date = new Date("2016/01/02 10:00 GMT-08000")
18 assertEquals(NaN, date.getMinutes());
OLDNEW
« no previous file with comments | « src/dateparser-inl.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698