Accept time zones like GMT-8 in the legacy date parser

Accept time zones like GMT-8 in the legacy date parser

In the Date constructor or Date.parse, other browsers will accept time
zones like GMT-8, but before this patch, Chrome would interpret 8 as
8 minutes. This patch interprets GMT-+ a one or two digit number as hours,
not minutes.

R=adamk,jshin@chromium.org
LOG=Y
BUG=chromium:422858
Committed: https://crrev.com/acbd64be36dec5a65d09106399b446b7c779adea
Cr-Commit-Position: refs/heads/master@{#33100}

[Dan Ehrenberg, 2016-01-04 19:10:12]

The CQ bit was checked by littledan@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-01-04 19:10:17]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1557053002/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1557053002/1

[Dan Ehrenberg, 2016-01-04 19:15:18]

Description was changed from

==========
Accept time zones like GMT-8 in the legacy date parser

It turns out that all the other browsers will accept time zones in
'legacy' date formats in the form of GMT-8, but Chrome would treat
that time zone as offset by 8 minutes, rather than 8 hours. This
patch interprets GMT-+ a one or two digit number as hours, not
minutes.

R=adamk,jshin@chromium.org
LOG=Y
BUG=chromium:422858
==========

to

==========
Accept time zones like GMT-8 in the legacy date parser

In the Date constructor or Date.parse, other browsers will accept time
zones like GMT-8, but before this patch, Chrome would interpret 8 as
8 minutes. This patch interprets GMT-+ a one or two digit number as hours,
not minutes.

R=adamk,jshin@chromium.org
LOG=Y
BUG=chromium:422858
==========

[commit-bot: I haz the power, 2016-01-04 19:29:22]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-01-04 19:29:22]

Dry run: This issue passed the CQ dry run.

[jungshik at Google, 2016-01-04 20:05:08]

Thanks. LGTM

https://codereview.chromium.org/1557053002/diff/1/test/mjsunit/regress/regres...
File test/mjsunit/regress/regress-crbug-422858.js (right):

https://codereview.chromium.org/1557053002/diff/1/test/mjsunit/regress/regres...
test/mjsunit/regress/regress-crbug-422858.js:6: assertEquals(0,
date.getMinutes());
Would it be a good idea to check hours as well ?

[adamk, 2016-01-04 20:56:07]

lgtm

[Dan Ehrenberg, 2016-01-04 23:03:42]

The CQ bit was checked by littledan@chromium.org

[Dan Ehrenberg, 2016-01-04 23:03:43]

The patchset sent to the CQ was uploaded after l-g-t-m from jshin@chromium.org,
adamk@chromium.org
Link to the patchset: https://codereview.chromium.org/1557053002/#ps20001
(title: "Test hours")

[commit-bot: I haz the power, 2016-01-04 23:03:49]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1557053002/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1557053002/20001

[Dan Ehrenberg, 2016-01-04 23:03:53]

https://codereview.chromium.org/1557053002/diff/1/test/mjsunit/regress/regres...
File test/mjsunit/regress/regress-crbug-422858.js (right):

https://codereview.chromium.org/1557053002/diff/1/test/mjsunit/regress/regres...
test/mjsunit/regress/regress-crbug-422858.js:6: assertEquals(0,
date.getMinutes());
On 2016/01/04 at 20:05:08, jshin (out until Jan 3) wrote:
> Would it be a good idea to check hours as well ?

Good point; done

[commit-bot: I haz the power, 2016-01-04 23:25:31]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-01-04 23:26:03]

Description was changed from

==========
Accept time zones like GMT-8 in the legacy date parser

In the Date constructor or Date.parse, other browsers will accept time
zones like GMT-8, but before this patch, Chrome would interpret 8 as
8 minutes. This patch interprets GMT-+ a one or two digit number as hours,
not minutes.

R=adamk,jshin@chromium.org
LOG=Y
BUG=chromium:422858
==========

to

==========
Accept time zones like GMT-8 in the legacy date parser

In the Date constructor or Date.parse, other browsers will accept time
zones like GMT-8, but before this patch, Chrome would interpret 8 as
8 minutes. This patch interprets GMT-+ a one or two digit number as hours,
not minutes.

R=adamk,jshin@chromium.org
LOG=Y
BUG=chromium:422858

Committed: https://crrev.com/acbd64be36dec5a65d09106399b446b7c779adea
Cr-Commit-Position: refs/heads/master@{#33100}
==========

[commit-bot: I haz the power, 2016-01-04 23:26:04]

Patchset 2 (id:??) landed as
https://crrev.com/acbd64be36dec5a65d09106399b446b7c779adea
Cr-Commit-Position: refs/heads/master@{#33100}