Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(256)

Issue 1556993004: [arm64] Fix AssertStackConsistency. (Closed)

Created:
4 years, 11 months ago by jbramley
Modified:
4 years, 11 months ago
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[arm64] Fix AssertStackConsistency. The implementation temporarily modifies jssp to avoid needing a scratch register, then restores it afterwards. However, the exception path wasn't properly restoring the value. With this patch, failures in this part of AssertStackConsistency get reported properly (with backtrace and a BailoutReason). BUG= Committed: https://crrev.com/f7c7cb8fe4ff9d37cba4fcc4310bcf6a812eb060 Cr-Commit-Position: refs/heads/master@{#33135}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -0 lines) Patch
M src/arm64/macro-assembler-arm64.cc View 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
jbramley
4 years, 11 months ago (2016-01-05 16:58:19 UTC) #2
Benedikt Meurer
LGTM.
4 years, 11 months ago (2016-01-05 18:10:57 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1556993004/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1556993004/1
4 years, 11 months ago (2016-01-06 09:11:21 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 11 months ago (2016-01-06 09:43:34 UTC) #6
commit-bot: I haz the power
4 years, 11 months ago (2016-01-06 09:43:54 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/f7c7cb8fe4ff9d37cba4fcc4310bcf6a812eb060
Cr-Commit-Position: refs/heads/master@{#33135}

Powered by Google App Engine
This is Rietveld 408576698