Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(515)

Issue 1556993002: [gn] Detect location of Visual Studio in the registry. (Closed)

Created:
4 years, 11 months ago by Daniel Bratell
Modified:
4 years, 11 months ago
Reviewers:
scottmg, brucedawson
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[gn] Detect location of Visual Studio in the registry. Look in the registry to figure out where Visual Studio is located on the disk. BUG=460462 Committed: https://crrev.com/c7af879c6c72db32930e25f20f9a9f602f11840c Cr-Commit-Position: refs/heads/master@{#368089}

Patch Set 1 #

Total comments: 2

Patch Set 2 : Let setup_toolchain.py use vs_toolchain.py #

Total comments: 15

Patch Set 3 : Review fixes. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+76 lines, -2 lines) Patch
M build/toolchain/win/setup_toolchain.py View 1 2 3 chunks +14 lines, -2 lines 0 comments Download
M build/vs_toolchain.py View 1 2 1 chunk +62 lines, -0 lines 0 comments Download

Messages

Total messages: 15 (4 generated)
Daniel Bratell
I know this basically adds the same 50 lines to two different files but I'm ...
4 years, 11 months ago (2016-01-04 17:05:38 UTC) #2
Daniel Bratell
Also, I should mention that this is a stripped down version of what gyp does.
4 years, 11 months ago (2016-01-04 17:12:06 UTC) #3
brucedawson
I'm surprised this is defaulting to 2015 since we haven't switched yet. Two (matching) lines ...
4 years, 11 months ago (2016-01-04 21:36:06 UTC) #4
Daniel Bratell
On 2016/01/04 21:36:06, brucedawson wrote: > I'm surprised this is defaulting to 2015 since we ...
4 years, 11 months ago (2016-01-05 08:58:56 UTC) #5
Daniel Bratell
I found that tools/clang/scripts/update.py already uses vs_toolchain.py so I let setup_toolchain.py do the same thing. ...
4 years, 11 months ago (2016-01-05 09:22:54 UTC) #6
brucedawson
lgtm, but you might want to see if scottmg has any thoughts on it.
4 years, 11 months ago (2016-01-05 22:31:05 UTC) #7
scottmg
lgtm https://codereview.chromium.org/1556993002/diff/20001/build/toolchain/win/setup_toolchain.py File build/toolchain/win/setup_toolchain.py (right): https://codereview.chromium.org/1556993002/diff/20001/build/toolchain/win/setup_toolchain.py#newcode59 build/toolchain/win/setup_toolchain.py:59: """Return path to the GYP_MSVS_VERSION of Visual Studio ...
4 years, 11 months ago (2016-01-05 23:30:32 UTC) #8
Daniel Bratell
https://codereview.chromium.org/1556993002/diff/20001/build/toolchain/win/setup_toolchain.py File build/toolchain/win/setup_toolchain.py (right): https://codereview.chromium.org/1556993002/diff/20001/build/toolchain/win/setup_toolchain.py#newcode59 build/toolchain/win/setup_toolchain.py:59: """Return path to the GYP_MSVS_VERSION of Visual Studio On ...
4 years, 11 months ago (2016-01-07 16:10:48 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1556993002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1556993002/40001
4 years, 11 months ago (2016-01-07 16:11:15 UTC) #12
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years, 11 months ago (2016-01-07 16:30:20 UTC) #13
commit-bot: I haz the power
4 years, 11 months ago (2016-01-07 16:32:17 UTC) #15
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/c7af879c6c72db32930e25f20f9a9f602f11840c
Cr-Commit-Position: refs/heads/master@{#368089}

Powered by Google App Engine
This is Rietveld 408576698