Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(518)

Unified Diff: ports/giflib/build.sh

Issue 1556933002: Remove redundant pnacl translations (Closed) Base URL: https://chromium.googlesource.com/webports.git@master
Patch Set: Created 4 years, 12 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: ports/giflib/build.sh
diff --git a/ports/giflib/build.sh b/ports/giflib/build.sh
index 754e3edccff2605ea654167ff644931cb66faf3b..1538bb3f04674e0d2551ca7b2878e262b2d1a0cf 100644
--- a/ports/giflib/build.sh
+++ b/ports/giflib/build.sh
@@ -6,25 +6,24 @@ EXTRA_CONFIGURE_ARGS="--enable-x11=no"
EXECUTABLES="util/rgb2gif${NACL_EXEEXT}"
RunTest() {
- util/rgb2gif -s 320 200 < ${SRC_DIR}/tests/porsche.rgb > porsche.gif
+ echo "Running util/rgb2gif on porsche.rgb"
+ util/rgb2gif -s 320 200 < ${SRC_DIR}/tests/porsche.rgb > porsche.gif
# TODO(sbc): do some basic checks on the resulting porsche.gif
}
TestStep() {
- if [ "${NACL_LIBC}" = "glibc" ]; then
+ if [[ ${NACL_LIBC} == glibc ]]; then
# TODO(sbc): find out why glibc version of rgb2gif is crashing
return
fi
- if [ "${NACL_ARCH}" = "pnacl" ]; then
- local pexe=rgb2gif${NACL_EXEEXT}
- (cd util;
- TranslateAndWriteLauncherScript ${pexe} x86-32 rgb2gif.x86-32.nexe rgb2gif)
- RunTest
- (cd util;
- TranslateAndWriteLauncherScript ${pexe} x86-64 rgb2gif.x86-64.nexe rgb2gif)
+ RunTest
+
+ if [[ ${NACL_ARCH} == pnacl ]]; then
+ # Re-run tests with arm and x86-32 translations
+ WriteLauncherScript util/rgb2gif rgb2gif.x86-32.nexe
RunTest
- else
+ WriteLauncherScript util/rgb2gif rgb2gif.arm.nexe
RunTest
fi
}

Powered by Google App Engine
This is Rietveld 408576698