Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(559)

Issue 1556933002: Remove redundant pnacl translations (Closed)

Created:
4 years, 11 months ago by Sam Clegg
Modified:
4 years, 11 months ago
Reviewers:
binji
CC:
native-client-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/webports.git@master
Target Ref:
refs/heads/master
Project:
webports
Visibility:
Public.

Description

Remove redundant pnacl translations Remove most uses of TranslateAndWriteLauncherScript since translation is already done by default for all EXECUTABLES. Remove WriteLauncherScriptPNaCl since its not different to the default WriteLauncherScript. Write launcher scripts for each executable post-build for PNaCl as well as non-PNaCl. R=binji@chromium.org Committed: https://chromium.googlesource.com/webports/+/0fe81bc2398acd17dee6dfc5b5f3d839f27c1b7e

Patch Set 1 #

Patch Set 2 : #

Total comments: 3
Unified diffs Side-by-side diffs Delta from patch set Stats (+58 lines, -145 lines) Patch
M build_tools/common.sh View 3 chunks +11 lines, -27 lines 1 comment Download
M ports/curl/build.sh View 1 chunk +0 lines, -8 lines 0 comments Download
M ports/devil/build.sh View 1 chunk +2 lines, -9 lines 0 comments Download
M ports/fftw-float/build.sh View 1 1 chunk +5 lines, -6 lines 1 comment Download
M ports/fftw/build.sh View 1 1 chunk +5 lines, -6 lines 0 comments Download
M ports/giflib/build.sh View 1 chunk +9 lines, -10 lines 0 comments Download
M ports/jpeg6b/build.sh View 1 chunk +1 line, -1 line 1 comment Download
M ports/jpeg8d/build.sh View 1 1 chunk +13 lines, -12 lines 0 comments Download
M ports/lua/build.sh View 1 chunk +0 lines, -8 lines 0 comments Download
M ports/python/build.sh View 1 chunk +0 lines, -13 lines 0 comments Download
M ports/python3/build.sh View 1 chunk +0 lines, -13 lines 0 comments Download
M ports/ruby/build.sh View 1 chunk +0 lines, -8 lines 0 comments Download
M ports/yajl/build.sh View 1 chunk +6 lines, -6 lines 0 comments Download
M ports/zlib/build.sh View 1 chunk +6 lines, -18 lines 0 comments Download

Messages

Total messages: 9 (4 generated)
Sam Clegg
4 years, 11 months ago (2016-01-04 13:42:43 UTC) #2
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1556933002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1556933002/20001
4 years, 11 months ago (2016-01-04 13:42:53 UTC) #4
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: webports-linux-clang-2 on tryserver.nacl (JOB_FAILED, http://build.chromium.org/p/tryserver.nacl/builders/webports-linux-clang-2/builds/30)
4 years, 11 months ago (2016-01-04 17:15:09 UTC) #6
binji
lgtm https://codereview.chromium.org/1556933002/diff/20001/build_tools/common.sh File build_tools/common.sh (right): https://codereview.chromium.org/1556933002/diff/20001/build_tools/common.sh#newcode1219 build_tools/common.sh:1219: nexe=${basename}.x86-64.nexe we assume x86_64 host? https://codereview.chromium.org/1556933002/diff/20001/ports/fftw-float/build.sh File ports/fftw-float/build.sh ...
4 years, 11 months ago (2016-01-04 19:37:03 UTC) #7
Sam Clegg
4 years, 11 months ago (2016-01-07 13:59:28 UTC) #9
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as
0fe81bc2398acd17dee6dfc5b5f3d839f27c1b7e (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698