Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(530)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1556913002: Use register arguments for RestParamAccessStub (Closed)

Created:
4 years, 11 months ago by mvstanton
Modified:
4 years, 11 months ago
Reviewers:
Benedikt Meurer
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Use register arguments for RestParamAccessStub This is preferable because in TurboFan we need to call it, and can't pass untagged external pointers on the stack. R=bmeurer@chromium.org Committed: https://crrev.com/82ca2a414deb4221100562a0fb2af0f216c4c3ef Cr-Commit-Position: refs/heads/master@{#33084}

Patch Set 1 #

Patch Set 2 : Ports. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+203 lines, -109 lines) Patch
M src/arm/code-stubs-arm.cc View 1 1 chunk +10 lines, -12 lines 0 comments Download
M src/arm/interface-descriptors-arm.cc View 1 1 chunk +6 lines, -0 lines 0 comments Download
M src/arm64/code-stubs-arm64.cc View 1 3 chunks +16 lines, -13 lines 0 comments Download
M src/arm64/interface-descriptors-arm64.cc View 1 1 chunk +6 lines, -0 lines 0 comments Download
M src/code-stubs.h View 1 chunk +1 line, -4 lines 0 comments Download
M src/full-codegen/arm/full-codegen-arm.cc View 1 1 chunk +9 lines, -5 lines 0 comments Download
M src/full-codegen/arm64/full-codegen-arm64.cc View 1 1 chunk +9 lines, -5 lines 0 comments Download
M src/full-codegen/ia32/full-codegen-ia32.cc View 1 chunk +8 lines, -5 lines 0 comments Download
M src/full-codegen/mips/full-codegen-mips.cc View 1 1 chunk +9 lines, -5 lines 0 comments Download
M src/full-codegen/mips64/full-codegen-mips64.cc View 1 1 chunk +9 lines, -5 lines 0 comments Download
M src/full-codegen/x64/full-codegen-x64.cc View 1 1 chunk +7 lines, -5 lines 0 comments Download
M src/ia32/code-stubs-ia32.cc View 1 chunk +14 lines, -9 lines 0 comments Download
M src/ia32/interface-descriptors-ia32.cc View 1 chunk +6 lines, -0 lines 0 comments Download
M src/interface-descriptors.h View 2 chunks +12 lines, -0 lines 0 comments Download
M src/interface-descriptors.cc View 1 chunk +22 lines, -0 lines 0 comments Download
M src/mips/code-stubs-mips.cc View 1 1 chunk +11 lines, -13 lines 0 comments Download
M src/mips/interface-descriptors-mips.cc View 1 1 chunk +6 lines, -0 lines 0 comments Download
M src/mips64/code-stubs-mips64.cc View 1 1 chunk +11 lines, -13 lines 0 comments Download
M src/mips64/interface-descriptors-mips64.cc View 1 1 chunk +6 lines, -0 lines 0 comments Download
M src/runtime/runtime-scopes.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M src/x64/code-stubs-x64.cc View 1 1 chunk +17 lines, -13 lines 0 comments Download
M src/x64/interface-descriptors-x64.cc View 1 1 chunk +6 lines, -0 lines 0 comments Download

Messages

Total messages: 10 (4 generated)
mvstanton
Hi Benedikt, here is the change we discussed. Thanks for the look! --Mike
4 years, 11 months ago (2016-01-04 13:33:39 UTC) #1
Benedikt Meurer
Very nice. Thanks. LGTM!
4 years, 11 months ago (2016-01-04 13:37:10 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1556913002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1556913002/20001
4 years, 11 months ago (2016-01-04 13:58:53 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1556913002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1556913002/20001
4 years, 11 months ago (2016-01-04 14:42:14 UTC) #7
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 11 months ago (2016-01-04 14:50:23 UTC) #8
commit-bot: I haz the power
4 years, 11 months ago (2016-01-04 14:51:04 UTC) #10
Message was sent while issue was closed. 
Patchset 2 (id:??) landed as
https://crrev.com/82ca2a414deb4221100562a0fb2af0f216c4c3ef
Cr-Commit-Position: refs/heads/master@{#33084}

Powered by Google App Engine
This is Rietveld 408576698